You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by Todd Volkert <tv...@gmail.com> on 2009/08/05 13:16:22 UTC
Diversity of committership
Gang:
For those of you who aren't subscribed to the general@ list, there's an
active debate going on right now as to whether we have enough diversity of
committership to warrant graduating. Regardless of how the vote goes,
people are bringing up good points about how we as a project should be
striving to get all of our committers more active in the codebase. Along
those lines, I did a quick run through JIRA to see if there were any tickets
that might be good candidates to encourage the group at large to tackle.
Here's what I came up with:
Low hanging fruit. These tickets are currently assigned to Greg, but they
really could be taken on by anybody - is anyone game to tackle one?
- PIVOT-129: Review thread prioritization
- PIVOT-173: Add bounds checks on skin styles
More involved. The additions to Meter would be a great way for someone to
get comfortable writing actual components and skins. These would be more
involved than the previous category, but it'd be great if someone wanted to
"own" Meter. I own it right now, but if someone's interested, I'd be happy
to guide them in the implementation of these tickets.
- PIVOT-26: Add orientation to Meter component
- PIVOT-33: Add support for Meter#text property in TerraMeterSkin
Already assigned. These tickets are already assigned to Sandro, Chris, and
Noel. Any chance anyone has some time to work on them?
- PIVOT-140: Create Demos for other major JVM Scripting languages
- PIVOT-43: Add support for digest authentication to web queries
- PIVOT-180: Add Resources.parent (resource hierarchy)
- PIVOT-78: implement a font chooser widget
- PIVOT-77: implement a color chooser widget
Cheers,
-T
Re: Diversity of committership
Posted by Christopher Brind <br...@brindy.org.uk>.
Created PIVOT-205 and assigned to myself.
Cheers,
Chris
2009/8/5 Martijn Dashorst <ma...@gmail.com>
> the more unit tests the merrier
>
> Martijn
>
> On Wed, Aug 5, 2009 at 2:01 PM, Christopher Brind<br...@brindy.org.uk>
> wrote:
> > I've been awful at committing, sorry.
> >
> > I'll pick up PIVOT-180 ASAP and then look at others shortly after that.
> >
> > I had also planned on writing unit tests for the Collections classes, but
> > abandoned that until after we changed package names and then forgot. If
> you
> > think it is worth it I can pick that up again as well? Feel free to add
> an
> > issue and assign to me.
> >
> > Cheers,
> > Chris
> >
> >
> >
> > 2009/8/5 Todd Volkert <tv...@gmail.com>
> >
> >> Gang:
> >>
> >> For those of you who aren't subscribed to the general@ list, there's an
> >> active debate going on right now as to whether we have enough diversity
> of
> >> committership to warrant graduating. Regardless of how the vote goes,
> >> people are bringing up good points about how we as a project should be
> >> striving to get all of our committers more active in the codebase.
> Along
> >> those lines, I did a quick run through JIRA to see if there were any
> >> tickets
> >> that might be good candidates to encourage the group at large to tackle.
> >> Here's what I came up with:
> >>
> >> Low hanging fruit. These tickets are currently assigned to Greg, but
> they
> >> really could be taken on by anybody - is anyone game to tackle one?
> >>
> >> - PIVOT-129: Review thread prioritization
> >> - PIVOT-173: Add bounds checks on skin styles
> >>
> >> More involved. The additions to Meter would be a great way for someone
> to
> >> get comfortable writing actual components and skins. These would be
> more
> >> involved than the previous category, but it'd be great if someone wanted
> to
> >> "own" Meter. I own it right now, but if someone's interested, I'd be
> happy
> >> to guide them in the implementation of these tickets.
> >>
> >> - PIVOT-26: Add orientation to Meter component
> >> - PIVOT-33: Add support for Meter#text property in TerraMeterSkin
> >>
> >> Already assigned. These tickets are already assigned to Sandro, Chris,
> and
> >> Noel. Any chance anyone has some time to work on them?
> >>
> >> - PIVOT-140: Create Demos for other major JVM Scripting languages
> >> - PIVOT-43: Add support for digest authentication to web queries
> >> - PIVOT-180: Add Resources.parent (resource hierarchy)
> >> - PIVOT-78: implement a font chooser widget
> >> - PIVOT-77: implement a color chooser widget
> >>
> >> Cheers,
> >> -T
> >>
> >
>
>
>
> --
> Become a Wicket expert, learn from the best: http://wicketinaction.com
> Apache Wicket 1.4 increases type safety for web applications
> Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.4.0
>
Re: Diversity of committership
Posted by Martijn Dashorst <ma...@gmail.com>.
the more unit tests the merrier
Martijn
On Wed, Aug 5, 2009 at 2:01 PM, Christopher Brind<br...@brindy.org.uk> wrote:
> I've been awful at committing, sorry.
>
> I'll pick up PIVOT-180 ASAP and then look at others shortly after that.
>
> I had also planned on writing unit tests for the Collections classes, but
> abandoned that until after we changed package names and then forgot. If you
> think it is worth it I can pick that up again as well? Feel free to add an
> issue and assign to me.
>
> Cheers,
> Chris
>
>
>
> 2009/8/5 Todd Volkert <tv...@gmail.com>
>
>> Gang:
>>
>> For those of you who aren't subscribed to the general@ list, there's an
>> active debate going on right now as to whether we have enough diversity of
>> committership to warrant graduating. Regardless of how the vote goes,
>> people are bringing up good points about how we as a project should be
>> striving to get all of our committers more active in the codebase. Along
>> those lines, I did a quick run through JIRA to see if there were any
>> tickets
>> that might be good candidates to encourage the group at large to tackle.
>> Here's what I came up with:
>>
>> Low hanging fruit. These tickets are currently assigned to Greg, but they
>> really could be taken on by anybody - is anyone game to tackle one?
>>
>> - PIVOT-129: Review thread prioritization
>> - PIVOT-173: Add bounds checks on skin styles
>>
>> More involved. The additions to Meter would be a great way for someone to
>> get comfortable writing actual components and skins. These would be more
>> involved than the previous category, but it'd be great if someone wanted to
>> "own" Meter. I own it right now, but if someone's interested, I'd be happy
>> to guide them in the implementation of these tickets.
>>
>> - PIVOT-26: Add orientation to Meter component
>> - PIVOT-33: Add support for Meter#text property in TerraMeterSkin
>>
>> Already assigned. These tickets are already assigned to Sandro, Chris, and
>> Noel. Any chance anyone has some time to work on them?
>>
>> - PIVOT-140: Create Demos for other major JVM Scripting languages
>> - PIVOT-43: Add support for digest authentication to web queries
>> - PIVOT-180: Add Resources.parent (resource hierarchy)
>> - PIVOT-78: implement a font chooser widget
>> - PIVOT-77: implement a color chooser widget
>>
>> Cheers,
>> -T
>>
>
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
Apache Wicket 1.4 increases type safety for web applications
Get it now: http://www.apache.org/dyn/closer.cgi/wicket/1.4.0
Re: Diversity of committership
Posted by Christopher Brind <br...@brindy.org.uk>.
I've been awful at committing, sorry.
I'll pick up PIVOT-180 ASAP and then look at others shortly after that.
I had also planned on writing unit tests for the Collections classes, but
abandoned that until after we changed package names and then forgot. If you
think it is worth it I can pick that up again as well? Feel free to add an
issue and assign to me.
Cheers,
Chris
2009/8/5 Todd Volkert <tv...@gmail.com>
> Gang:
>
> For those of you who aren't subscribed to the general@ list, there's an
> active debate going on right now as to whether we have enough diversity of
> committership to warrant graduating. Regardless of how the vote goes,
> people are bringing up good points about how we as a project should be
> striving to get all of our committers more active in the codebase. Along
> those lines, I did a quick run through JIRA to see if there were any
> tickets
> that might be good candidates to encourage the group at large to tackle.
> Here's what I came up with:
>
> Low hanging fruit. These tickets are currently assigned to Greg, but they
> really could be taken on by anybody - is anyone game to tackle one?
>
> - PIVOT-129: Review thread prioritization
> - PIVOT-173: Add bounds checks on skin styles
>
> More involved. The additions to Meter would be a great way for someone to
> get comfortable writing actual components and skins. These would be more
> involved than the previous category, but it'd be great if someone wanted to
> "own" Meter. I own it right now, but if someone's interested, I'd be happy
> to guide them in the implementation of these tickets.
>
> - PIVOT-26: Add orientation to Meter component
> - PIVOT-33: Add support for Meter#text property in TerraMeterSkin
>
> Already assigned. These tickets are already assigned to Sandro, Chris, and
> Noel. Any chance anyone has some time to work on them?
>
> - PIVOT-140: Create Demos for other major JVM Scripting languages
> - PIVOT-43: Add support for digest authentication to web queries
> - PIVOT-180: Add Resources.parent (resource hierarchy)
> - PIVOT-78: implement a font chooser widget
> - PIVOT-77: implement a color chooser widget
>
> Cheers,
> -T
>
Re: Diversity of committership
Posted by Sandro Martini <sa...@gmail.com>.
Hi Todd,
I have to start working on this next week, but after i first try I'll
post here a sample patch.
Next week I'll be in Holidays, so I don't know how many time I'll have
to work on Pivot.
At least I'll make things the week after ...
Bye
Re: Diversity of committership
Posted by Sandro Martini <sa...@gmail.com>.
Ok, tomorrow I'll start with a first example, to review with all ...
Byeeee
Re: Diversity of committership
Posted by Todd Volkert <tv...@gmail.com>.
I don't know that there are any examples, but it should be just a matter of
going through each skin, looking at each bean setter method within the skin,
and asking "are there any illegal values that we should be checking for
here?" Also, I think IllegalArgumentException is more appropriate here than
IllegalStateException.
-T
On Wed, Aug 5, 2009 at 11:06 AM, Sandro Martini <sa...@gmail.com>wrote:
> Ok, i can do it but if possible, could i have a minimal sample ?
> This would speed up my work.
>
> Thanks,
> Sandro
>
Re: Diversity of committership
Posted by Sandro Martini <sa...@gmail.com>.
Ok, i can do it but if possible, could i have a minimal sample ?
This would speed up my work.
Thanks,
Sandro
Re: Diversity of committership
Posted by Noel Grandin <no...@gmail.com>.
Sandro Martini wrote:
>
>>> - PIVOT-173: Add bounds checks on skin styles
>>>
> Maybe i could try with this ... but exactly what is expected to be done here ?
>
>
Means going through the various style setters and modifying the code to
throw IllegalStateException if the values are out of legal range.
For example, setting a width to less than zero. Or setting a scalar
enumerated value to something illegal.
Re: Diversity of committership
Posted by Sandro Martini <sa...@gmail.com>.
Hi,
>> - PIVOT-129: Review thread prioritization
Means the ability to change thread priority (so an implementation of
this has to be done), or to review existing threading and assign some
useful defaults to them ?
Suggestions / tests already done ?
>> - PIVOT-173: Add bounds checks on skin styles
Maybe i could try with this ... but exactly what is expected to be done here ?
Bye
Re: Diversity of committership
Posted by Noel Grandin <no...@gmail.com>.
Hi
I've got a baseline patch that I need to re-apply (the code has changed
too much since I wrote it).
Will get on it.
Regards, Noel.
Todd Volkert wrote:
> Gang:
>
> For those of you who aren't subscribed to the general@ list, there's an
> active debate going on right now as to whether we have enough diversity of
> committership to warrant graduating. Regardless of how the vote goes,
> people are bringing up good points about how we as a project should be
> striving to get all of our committers more active in the codebase. Along
> those lines, I did a quick run through JIRA to see if there were any tickets
> that might be good candidates to encourage the group at large to tackle.
> Here's what I came up with:
>
> Low hanging fruit. These tickets are currently assigned to Greg, but they
> really could be taken on by anybody - is anyone game to tackle one?
>
> - PIVOT-129: Review thread prioritization
> - PIVOT-173: Add bounds checks on skin styles
>
> More involved. The additions to Meter would be a great way for someone to
> get comfortable writing actual components and skins. These would be more
> involved than the previous category, but it'd be great if someone wanted to
> "own" Meter. I own it right now, but if someone's interested, I'd be happy
> to guide them in the implementation of these tickets.
>
> - PIVOT-26: Add orientation to Meter component
> - PIVOT-33: Add support for Meter#text property in TerraMeterSkin
>
> Already assigned. These tickets are already assigned to Sandro, Chris, and
> Noel. Any chance anyone has some time to work on them?
>
> - PIVOT-140: Create Demos for other major JVM Scripting languages
> - PIVOT-43: Add support for digest authentication to web queries
> - PIVOT-180: Add Resources.parent (resource hierarchy)
> - PIVOT-78: implement a font chooser widget
> - PIVOT-77: implement a color chooser widget
>
> Cheers,
> -T
>
>