You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Fero Szabo via Review Board <no...@reviews.apache.org> on 2018/09/03 09:46:06 UTC
Re: Review Request 68569: HiveMiniCluster does not restore
hive-site.xml location
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68569/#review208248
-----------------------------------------------------------
Ship it!
Ship It!
- Fero Szabo
On Aug. 30, 2018, 11:27 a.m., Szabolcs Vasas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68569/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2018, 11:27 a.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-3375
> https://issues.apache.org/jira/browse/SQOOP-3375
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> HiveMiniCluster sets the hive-site.xml location using org.apache.hadoop.hive.conf.HiveConf#setHiveSiteLocation static method during startup but it does not restore the original location during shutdown.
>
> This makes HCatalogImportTest and HCatalogExportTest fail if they are ran in the same JVM after any test using HiveMiniCluster.
>
>
> Diffs
> -----
>
> src/test/org/apache/sqoop/hive/minicluster/HiveMiniCluster.java 19bb7605c
>
>
> Diff: https://reviews.apache.org/r/68569/diff/1/
>
>
> Testing
> -------
>
> Executed unit and third party tests.
>
>
> Thanks,
>
> Szabolcs Vasas
>
>