You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/07/16 04:40:20 UTC
[PR] feat(i18n): backfill Romanian (ro) translations (AI-generated, needs review) [superset]
rusackas opened a new pull request, #42100:
URL: https://github.com/apache/superset/pull/42100
### SUMMARY
Backfills untranslated (empty `msgstr`) entries in the **Romanian (ro)** catalog using `scripts/translations/backfill_po.py`, with every other language's translation of the same string as cross-language context.
New entries are marked `#, fuzzy` with a `# Machine-translated via backfill_po.py` attribution for human review. Fuzzy entries **are** served (backend compiles `--use-fuzzy`, frontend uses `po2json --fuzzy`), so the translations reach users on build while remaining reviewable.
Romanian had the largest backlog — it was skipped in the original AI backfill sweep as "already complete" but had ~620 untranslated strings.
Split out from the combined backfill PR (#42099) because this catalog needed a larger canonical-reformatting pass; the bulk of the diff is normalize re-wrapping, not new content.
### TESTING INSTRUCTIONS
QA before opening: **616 entries filled**, 0 placeholder mismatches, `msgfmt -c` clean, 0 existing translations altered (only empty entries filled + canonical re-wrap).
### ADDITIONAL INFORMATION
- [x] Changes UI (translated strings)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(i18n): backfill Romanian (ro) translations (AI-generated, needs review) [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #42100:
URL: https://github.com/apache/superset/pull/42100#issuecomment-4988443915
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/42100?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 65.02%. Comparing base ([`8ce6d42`](https://app.codecov.io/gh/apache/superset/commit/8ce6d42942801f9dbc9e6382924424d7d64c6545?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`4fec852`](https://app.codecov.io/gh/apache/superset/commit/4fec85237f6df261248776a2ce82db8583d7c2b2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #42100 +/- ##
=======================================
Coverage 65.02% 65.02%
=======================================
Files 2752 2752
Lines 154390 154390
Branches 35380 35380
=======================================
Hits 100391 100391
Misses 52088 52088
Partials 1911 1911
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/42100/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/42100/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.03% <ø> (ø)` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/42100/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.76% <ø> (ø)` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/42100/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.81% <ø> (ø)` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/42100/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.00% <ø> (ø)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/42100/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.25% <ø> (ø)` | |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/42100/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.42% <ø> (ø)` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/42100/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/42100?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(i18n): backfill Romanian (ro) translations (AI-generated, needs review) [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #42100:
URL: https://github.com/apache/superset/pull/42100#issuecomment-4988566536
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 3e72c5da2e7b66182534af273f508e80bc61a003 |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a586d637964d00008dc2e19 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-42100--superset-docs-preview.netlify.app](https://deploy-preview-42100--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#q1YqKMrPLShRslJS0lFKKkrMS84AstNSE0v0Mw0t8nSL8nVLgKLFOYklmfl5xUBFKakFOfmVnilAZWaJphZmKWbG5pZmJikGQGCRkmyUamipVAsA) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-42100--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(i18n): backfill Romanian (ro) translations (AI-generated, needs review) [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #42100:
URL: https://github.com/apache/superset/pull/42100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(i18n): backfill Romanian (ro) translations (AI-generated, needs review) [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #42100:
URL: https://github.com/apache/superset/pull/42100#discussion_r3592892179
##########
superset/translations/ro/LC_MESSAGES/messages.po:
##########
@@ -2243,10 +2481,15 @@ msgstr ""
"Sigur doriți să eliminați tema implicită a sistemului? Aplicația va "
"reveni la valoarea implicită din fișierul de configurare."
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, ja, sr,
+# sr_Latn]
+#, fuzzy
msgid ""
"Are you sure you want to revoke this API key? This action cannot be "
"undone."
msgstr ""
+"Ești sigur că vrei să revoce această cheie API? Această acțiune nu poate "
+"fi anulată."
Review Comment:
Good catch, fixed. 'vrei să revoce' to 'vrei să revoci'.
##########
superset/translations/ro/LC_MESSAGES/messages.po:
##########
@@ -2320,20 +2566,29 @@ msgstr "Auto"
msgid "Auto Zoom"
msgstr "Zoom Automat"
-#, python-format
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, ja, sr,
+# sr_Latn]
+#, fuzzy, python-format
msgid "Auto refresh paused (set to %s seconds)"
-msgstr ""
+msgstr "Reîmprospătare automată pausată (setată la %s secunde)"
-#, python-format
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, ja, sr,
+# sr_Latn]
Review Comment:
Fixed, 'pausată' to 'pauzată'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(i18n): backfill Romanian (ro) translations (AI-generated, needs review) [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #42100:
URL: https://github.com/apache/superset/pull/42100#discussion_r3592698257
##########
superset/translations/ro/LC_MESSAGES/messages.po:
##########
@@ -2320,20 +2566,29 @@ msgstr "Auto"
msgid "Auto Zoom"
msgstr "Zoom Automat"
-#, python-format
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, ja, sr,
+# sr_Latn]
+#, fuzzy, python-format
msgid "Auto refresh paused (set to %s seconds)"
-msgstr ""
+msgstr "Reîmprospătare automată pausată (setată la %s secunde)"
-#, python-format
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, ja, sr,
+# sr_Latn]
Review Comment:
**Suggestion:** There is an obvious typo in the Romanian translation (`pausată` instead of `pauzată`). Since this string is user-facing in auto-refresh status messages, fix the misspelling to avoid showing incorrect UI text. [typo]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
❌ Auto-refresh tooltip shows misspelled Romanian status text.
⚠️ Romanian dashboard users see lower-quality localization.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Open a dashboard and enable auto refresh so that the auto-refresh status tooltip
appears (frontend component located at
`superset-frontend/src/dashboard/components/AutoRefreshStatus/StatusTooltipContent.tsx:160`,
which calls `t('Auto refresh paused (set to %s seconds)', refreshFrequency)`).
2. Switch the Superset UI language to Romanian, which loads translations from
`superset/translations/ro/LC_MESSAGES/messages.po` where the msgid `Auto refresh paused
(set to %s seconds)` is translated at lines 2575-2576 as `Reîmprospătare automată pausată
(setată la %s secunde)`.
3. Trigger the "paused" state for auto-refresh (e.g., by hitting the pause control in the
dashboard header, handled in the same `StatusTooltipContent` component), causing the
tooltip to display the Romanian translation.
4. Observe in the rendered Romanian UI that the adjective appears as `pausată`, which is a
typographical error (the correct Romanian form is `pauzată`), so the auto-refresh status
message shown to users is misspelled.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=a51d524038554c308da38e48b526ee01&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=a51d524038554c308da38e48b526ee01&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/ro/LC_MESSAGES/messages.po
**Line:** 2575:2576
**Comment:**
*Typo: There is an obvious typo in the Romanian translation (`pausată` instead of `pauzată`). Since this string is user-facing in auto-refresh status messages, fix the misspelling to avoid showing incorrect UI text.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42100&comment_hash=00d9ba4a9c9373381168b6c336a82e1a64e9f1cd7cf9f87947b6a2113a83a4a4&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42100&comment_hash=00d9ba4a9c9373381168b6c336a82e1a64e9f1cd7cf9f87947b6a2113a83a4a4&reaction=dislike'>👎</a>
##########
superset/translations/ro/LC_MESSAGES/messages.po:
##########
@@ -2243,10 +2481,15 @@ msgstr ""
"Sigur doriți să eliminați tema implicită a sistemului? Aplicația va "
"reveni la valoarea implicită din fișierul de configurare."
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, ja, sr,
+# sr_Latn]
+#, fuzzy
msgid ""
"Are you sure you want to revoke this API key? This action cannot be "
"undone."
msgstr ""
+"Ești sigur că vrei să revoce această cheie API? Această acțiune nu poate "
+"fi anulată."
Review Comment:
**Suggestion:** The Romanian translation uses an incorrect verb form (`vrei să revoce`) that is grammatically wrong in this confirmation dialog and reads as a typo; update it to the correct second-person form so the revoke confirmation is clear and correct. [typo]
<details>
<summary><b>Severity Level:</b> Major ⚠️</summary>
```mdx
❌ API key revoke dialog shows grammatically incorrect Romanian text.
⚠️ Confusing wording in Romanian for critical revoke confirmation.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Navigate to the API keys management UI where revocation is handled in
`superset-frontend/src/features/apiKeys/ApiKeyList.tsx:83-89`, which uses `t('Are you sure
you want to revoke this API key? This action cannot be undone.')` as the confirmation
dialog content.
2. Switch the Superset interface language to Romanian, so the msgid `Are you sure you want
to revoke this API key? This action cannot be undone.` resolves to the Romanian
translation in `superset/translations/ro/LC_MESSAGES/messages.po` at lines 2488-2493.
3. Click the revoke action for an API key so that the AntD confirmation modal is shown,
pulling the Romanian msgstr:
- `Ești sigur că vrei să revoce această cheie API? Această acțiune nu poate fi
anulată.`
4. Observe in the displayed confirmation dialog that the verb phrase `vrei să revoce` is
grammatically incorrect in Romanian (it should be second person `vrei să revoci`), so the
revoke prompt in a security-sensitive flow appears with a clear language error to users.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=88406b0cf16a46adb65788270ef2bceb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=88406b0cf16a46adb65788270ef2bceb&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/translations/ro/LC_MESSAGES/messages.po
**Line:** 2488:2493
**Comment:**
*Typo: The Romanian translation uses an incorrect verb form (`vrei să revoce`) that is grammatically wrong in this confirmation dialog and reads as a typo; update it to the correct second-person form so the revoke confirmation is clear and correct.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42100&comment_hash=b2b27523961c4385b36de655dd9bb81c2d071272766ee432c74fa3ca7ff3df4f&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42100&comment_hash=b2b27523961c4385b36de655dd9bb81c2d071272766ee432c74fa3ca7ff3df4f&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(i18n): backfill Romanian (ro) translations (AI-generated, needs review) [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42100:
URL: https://github.com/apache/superset/pull/42100#issuecomment-4988246151
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(i18n): backfill Romanian (ro) translations (AI-generated, needs review) [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42100:
URL: https://github.com/apache/superset/pull/42100#issuecomment-4989875570
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org