You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/10/28 00:38:27 UTC
[jira] [Commented] (TINKERPOP3-926) Renamed TinkerGraph public
statics to common pattern used for other statics.
[ https://issues.apache.org/jira/browse/TINKERPOP3-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14977372#comment-14977372 ]
ASF GitHub Bot commented on TINKERPOP3-926:
-------------------------------------------
GitHub user okram opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/123
TINKERPOP3-926: Renamed TinkerGraph public statics to common pattern used for other statics.
https://issues.apache.org/jira/browse/TINKERPOP3-926
Renamed the `public statics` to use the standard TinkerPop pattern of spelling out the full property name is capital case with new words (and or camel case) having a `_` split.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-tinkerpop TINKERPOP3-926
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/123.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #123
----
commit 12de257cb43ea13b768ead04ce2a63108b608c8a
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2015-10-27T23:35:00Z
Fixed the .properties file keys consistent with TinkerPop pattern.
----
> Renamed TinkerGraph public statics to common pattern used for other statics.
> ----------------------------------------------------------------------------
>
> Key: TINKERPOP3-926
> URL: https://issues.apache.org/jira/browse/TINKERPOP3-926
> Project: TinkerPop 3
> Issue Type: Bug
> Components: tinkergraph
> Affects Versions: 3.0.2-incubating
> Reporter: Marko A. Rodriguez
> Assignee: Marko A. Rodriguez
> Fix For: 3.1.0-incubating
>
>
> These are bad. [~spmallette] Verify this isn't backwards compatible and I will fix it.
> {code}
> public static final String CONFIG_VERTEX_ID = "gremlin.tinkergraph.vertexIdManager";
> public static final String CONFIG_EDGE_ID = "gremlin.tinkergraph.edgeIdManager";
> public static final String CONFIG_VERTEX_PROPERTY_ID = "gremlin.tinkergraph.vertexPropertyIdManager";
> public static final String CONFIG_DEFAULT_VERTEX_PROPERTY_CARDINALITY = "gremlin.tinkergraph.defaultVertexPropertyCardinality";
> public static final String CONFIG_GRAPH_LOCATION = "gremlin.tinkergraph.graphLocation";
> public static final String CONFIG_GRAPH_FORMAT = "gremlin.tinkergraph.graphFormat";
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)