You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/29 12:08:38 UTC
[GitHub] [airflow] potiuk commented on a change in pull request #7947: Fixes
too high parallelism in CI
potiuk commented on a change in pull request #7947: Fixes too high parallelism in CI
URL: https://github.com/apache/airflow/pull/7947#discussion_r399788534
##########
File path: scripts/ci/in_container/entrypoint_ci.sh
##########
@@ -193,6 +193,15 @@ fi
# shellcheck source=scripts/ci/in_container/configure_environment.sh
. "${MY_DIR}/configure_environment.sh"
+if [[ ${CI:=} == "true" && ${RUN_TESTS} == "true" ]] ; then
+ echo
+ echo " !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
+ echo " Setting default parallellism to 4 because we can run out of memory during tests on CI"
+ echo " !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!"
+ echo
+ export AIRFLOW__CORE__PARALELLISM=4
Review comment:
I think it's better here to be only set for CI -> it's quite ok to have high parallelism for development I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services