You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/25 10:09:05 UTC

[GitHub] zhijiangW opened a new pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

zhijiangW opened a new pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment
URL: https://github.com/apache/flink/pull/7822
 
 
   ## What is the purpose of the change
   
   *The `ResultPartition` and `InputGate` are created in `Task` currently. Based on pluggable `ShuffleManager`, they should be created via `ShuffleService`.*
   
   *The `NetworkEnvironment` would be refactored into `NetworkShuffleService` future. So we could migrate the process of creating `ResultPartition` and `InputGate` into current `NetworkEnvironment`. The `BufferPool` and metrics setup can also be done along with the creations. Then we can remove the process of `NetworkEnvironment#registerTask`.*
   
   ## Brief change log
   
    - *Pass `IOManager` and `enableDetailedNetworkMetrics` in the constructor of `NetworkEnvironment`*
     - *Introduce `TaskId` field for identifying the unique task in `TaskInfo`*
     - *Introduce `NetworkEnvironment#createResultPartitionWriter` and `NetworkEnvironment#createInputGate` to refactor the process of creation of `ResultPartition` and `SingleInputGate` in `Task`*
     - *Modify the `TaskIOMetricGroup` for setting up the input and output metrics*
     - *Remove the explicit reference with `ResultPartition` and `SingleInputGate` in `Task`, which can be got directly from `NetworkEnvironment` by `TaskId`*
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *NetworkEnvironmentTest*, *TaskTest*.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services