You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/11/19 20:10:00 UTC
[jira] [Commented] (SOLR-15700) Fix include path consistency in bin/solr shell wrapper
[ https://issues.apache.org/jira/browse/SOLR-15700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446645#comment-17446645 ]
ASF subversion and git services commented on SOLR-15700:
--------------------------------------------------------
Commit cee22de67dbee70c48266b176401edf1e7427b11 in solr's branch refs/heads/main from turnertg
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=cee22de ]
SOLR-15700: Make include paths in bin/solr consistent (#358)
> Fix include path consistency in bin/solr shell wrapper
> ------------------------------------------------------
>
> Key: SOLR-15700
> URL: https://issues.apache.org/jira/browse/SOLR-15700
> Project: Solr
> Issue Type: Bug
> Components: scripts and tools
> Affects Versions: 8.10
> Environment: CentOS 7, Solr 8.10.1
> –
> openjdk version "11.0.12" 2021-07-20 LTS
> OpenJDK Runtime Environment 18.9 (build 11.0.12+7-LTS)
> OpenJDK 64-Bit Server VM 18.9 (build 11.0.12+7-LTS, mixed mode, sharing
> --
> GNU bash, version 4.2.46(2)-release (x86_64-redhat-linux-gnu)
> Copyright (C) 2011 Free Software Foundation, Inc.
> Reporter: Trevor Turner
> Assignee: David Eric Pugh
> Priority: Minor
> Labels: easyfix, patch, pull-request-available
> Attachments: fix-solr-sh-include-paths.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The shell script {{bin/solr}} states the paths it will search for {{solr.in.sh}} in a comment near the top of the script, however, not all of these paths are consistent with the logic that actually searches for the file.
> Since one can either edit the script in their own packaging/deployment or simply use the {{SOLR_INCLUDE}} env variable, this doesn't pose much of a problem, but is a minor annoyance if configuring a package based on this comment.
> I've created and attached a patch that includes all paths consistently in both places.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org