You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/07/12 06:13:12 UTC

[GitHub] [incubator-yunikorn-k8shim] 0yukali0 opened a new pull request #280: [YUNIKONR-706] Fix the resource calculation when the pod has init-containers

0yukali0 opened a new pull request #280:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/280


   ### What is this PR for?
   Original function will miss initcontainers requirement in podspec when pod has initcontainers and containers. 
   The reason is that resources calculation function only check resources requirement of containers in pod.
   I modify resource calculation in task which use function in common package to confirm it.
   
   ### What type of PR is it?
   * [x] - Bug Fix
   * [ ] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/YUNIKORN-706
   
   ### How should this be tested?
   I add test case to check calculation correctly.
   Use make test to recheck.
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * [ ] - The licenses files need update.
   * [ ] - There is breaking changes for older versions.
   * [ ] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] 0yukali0 closed pull request #280: [YUNIKONR-706] Fix the resource calculation when the pod has init-containers

Posted by GitBox <gi...@apache.org>.
0yukali0 closed pull request #280:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/280


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] 0yukali0 commented on pull request #280: [YUNIKONR-706] Fix the resource calculation when the pod has init-containers

Posted by GitBox <gi...@apache.org>.
0yukali0 commented on pull request #280:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/280#issuecomment-878004358


   Sorry , I just found out there is logic problem here.
   I will fix it and ask a PR later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org