You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/18 01:18:01 UTC
[GitHub] [apisix] tokers commented on a diff in pull request #7048: feat(ops): use lua libs to backup config file insteadof shell command
tokers commented on code in PR #7048:
URL: https://github.com/apache/apisix/pull/7048#discussion_r875387907
##########
apisix/cli/ops.lua:
##########
@@ -467,9 +469,8 @@ Please modify "admin_key" in conf/config.yaml .
-- Therefore we need to check the absolute version instead
cert_path = pl_path.abspath(cert_path)
- local ok, err = util.is_file_exist(cert_path)
- if not ok then
- util.die(err, "\n")
+ if not pl_path.exists(cert_path) then
+ util.die("certificate path", cert_path, "isn't exist\n")
Review Comment:
```suggestion
util.die("certificate path", cert_path, "doesn't exist\n")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org