You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by GitBox <gi...@apache.org> on 2021/12/31 02:15:57 UTC

[GitHub] [nutch] lewismc opened a new pull request #720: NUTCH-2429 Fix Plugin System to allow protocol plugins to bundle their URLStreamHandlers

lewismc opened a new pull request #720:
URL: https://github.com/apache/nutch/pull/720


   This issue addresses [NUTCH-2429](https://issues.apache.org/jira/browse/NUTCH-2429). Some notes
   * supersedes #222 by updating everything which was done there (excellent work @ HiranChaudhuri )
   * incorporates @sebastian-nagel work a la  [/sebastian-nagel/nutch/tree/NUTCH-2429](https://github.com/sebastian-nagel/nutch/commit/e589f05ef42486892427d347ecd10abfa9e380d7)
   * organizes the imports for each Class touched in this pull request
   * addresses a couple of rogue Classes which declared `public static final Logger` --> `private static final Logger`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nutch] lewismc merged pull request #720: NUTCH-2429 Fix Plugin System to allow protocol plugins to bundle their URLStreamHandlers

Posted by GitBox <gi...@apache.org>.
lewismc merged pull request #720:
URL: https://github.com/apache/nutch/pull/720


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nutch] lewismc commented on pull request #720: NUTCH-2429 Fix Plugin System to allow protocol plugins to bundle their URLStreamHandlers

Posted by GitBox <gi...@apache.org>.
lewismc commented on pull request #720:
URL: https://github.com/apache/nutch/pull/720#issuecomment-1003244488


   This should also pave the way for me to work on [NUTCH-2856](https://issues.apache.org/jira/browse/NUTCH-2856)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nutch] lewismc merged pull request #720: NUTCH-2429 Fix Plugin System to allow protocol plugins to bundle their URLStreamHandlers

Posted by GitBox <gi...@apache.org>.
lewismc merged pull request #720:
URL: https://github.com/apache/nutch/pull/720


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nutch] sebastian-nagel commented on pull request #720: NUTCH-2429 Fix Plugin System to allow protocol plugins to bundle their URLStreamHandlers

Posted by GitBox <gi...@apache.org>.
sebastian-nagel commented on pull request #720:
URL: https://github.com/apache/nutch/pull/720#issuecomment-1008078107


   +1 lgtm. Thanks, @lewismc!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [nutch] lewismc commented on pull request #720: NUTCH-2429 Fix Plugin System to allow protocol plugins to bundle their URLStreamHandlers

Posted by GitBox <gi...@apache.org>.
lewismc commented on pull request #720:
URL: https://github.com/apache/nutch/pull/720#issuecomment-1006017189


   I'll commit in 72 hrs unless there are objections.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org