[GitHub] [incubator-weex] YorkShen commented on a change in pull request #2248: [Android] Fire event when span within an a-label is clicked.

[GitBox <gi...@apache.org>]

YorkShen commented on a change in pull request #2248: [Android] Fire event when span within an a-label is clicked.
URL: https://github.com/apache/incubator-weex/pull/2248#discussion_r270782750
 
 

 ##########
 File path: android/sdk/src/main/java/com/taobao/weex/ui/component/richtext/node/ANode.java
 ##########
 @@ -54,7 +56,7 @@ protected boolean isInternalNode() {
   protected void updateSpans(SpannableStringBuilder spannableStringBuilder, int level) {
     super.updateSpans(spannableStringBuilder, level);
     if (attr != null && attr.containsKey(HREF)) {
-      ASpan aSpan = new ASpan(mInstanceId, attr.get(HREF).toString());
+      ASpan aSpan = new ASpan(mInstanceId, attr.get(HREF).toString(), mComponentRef,WXUtils.getString(attr.get(RichTextNode.PSEUDO_REF),""));
 
 Review comment:
   Why not just use `ItemClickSpan`?
   
   Ref [ImgNode](https://github.com/apache/incubator-weex/blob/12e605fdec041e2a661edf45470815595f0fca2d/android/sdk/src/main/java/com/taobao/weex/ui/component/richtext/node/ImgNode.java#L78-L81) for detail.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services