[jira] Closed: (MIME4J-73) IllegalArgumentException in Message constructor when parsing erroneous message

["Robert Burrell Donkin (JIRA)" <mi...@james.apache.org>]

     [ https://issues.apache.org/jira/browse/MIME4J-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Burrell Donkin closed MIME4J-73.
---------------------------------------


Closing all issues fixed previously, after a brief review of each.

> IllegalArgumentException in Message constructor when parsing erroneous message
> ------------------------------------------------------------------------------
>
>                 Key: MIME4J-73
>                 URL: https://issues.apache.org/jira/browse/MIME4J-73
>             Project: JAMES Mime4j
>          Issue Type: Bug
>    Affects Versions: 0.4
>            Reporter: Markus Wiederkehr
>             Fix For: 0.5
>
>         Attachments: mime4j-message-2.patch, mime4j-message.patch
>
>
> The constructor of Message(InputStream) uses its inner class MessageBuilder to parse the input stream and create the object. The method MessageBuilder.field(String) calls Field.parse(String) to parse header fields. This method throws an IllegalArgumentException on parse errors.
> Clearly the Message constructor should throw a MimeException instead of an IllegalArgumentException if an invalid header field is encountered (or else it should simply ignore the field). So either Field.parse(String) should throw a MimeException or MessageBuilder.field(String) should catch and convert it.
> And by the way, could you make MessageBuilder public so it can be extended if a slightly different behavior is desired.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.