You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@apex.apache.org by ajaygit158 <gi...@git.apache.org> on 2017/05/17 07:22:04 UTC

[GitHub] apex-malhar pull request #621: APEXMALHAR-2492 Correct usage of empty Slice ...

GitHub user ajaygit158 opened a pull request:

    https://github.com/apache/apex-malhar/pull/621

    APEXMALHAR-2492 Correct usage of empty Slice in Malhar Library

    @vlad There is another piece of code where there is possibility of creating a wrong empty Slice. 
    https://github.com/apache/apex-malhar/blob/master/library/src/test/java/org/apache/apex/malhar/lib/wal/FileSystemWALTest.java#L113
    Should we change the getRandomSlice() implementation if len = 0?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ajaygit158/apex-malhar APEXMALHAR-2492

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/apex-malhar/pull/621.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #621
    
----
commit a850bcf5a5b56cefee997dbae84921662c2e39bc
Author: ajaygit158 <aj...@gmail.com>
Date:   2017-05-17T05:55:33Z

    APEXMALHAR-2492 Correct usage of empty Slice in Malhar Library

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] apex-malhar pull request #621: APEXMALHAR-2492 Correct usage of empty Slice ...

Posted by ajaygit158 <gi...@git.apache.org>.

GitHub user ajaygit158 reopened a pull request:

    https://github.com/apache/apex-malhar/pull/621

    APEXMALHAR-2492 Correct usage of empty Slice in Malhar Library

    @vlad There is another piece of code where there is possibility of creating a wrong empty Slice. 
    https://github.com/apache/apex-malhar/blob/master/library/src/test/java/org/apache/apex/malhar/lib/wal/FileSystemWALTest.java#L113
    Should we change the getRandomSlice() implementation if len = 0?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ajaygit158/apex-malhar APEXMALHAR-2492

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/apex-malhar/pull/621.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #621
    
----
commit a850bcf5a5b56cefee997dbae84921662c2e39bc
Author: ajaygit158 <aj...@gmail.com>
Date:   2017-05-17T05:55:33Z

    APEXMALHAR-2492 Correct usage of empty Slice in Malhar Library

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] apex-malhar pull request #621: APEXMALHAR-2492 Correct usage of empty Slice ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/apex-malhar/pull/621


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] apex-malhar pull request #621: APEXMALHAR-2492 Correct usage of empty Slice ...

Posted by ajaygit158 <gi...@git.apache.org>.

Github user ajaygit158 closed the pull request at:

    https://github.com/apache/apex-malhar/pull/621


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---