You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by knusbaum <gi...@git.apache.org> on 2017/07/10 21:33:22 UTC
[GitHub] storm pull request #2202: STORM-2623: Add in a whitelist for scheduler strat...
GitHub user knusbaum opened a pull request:
https://github.com/apache/storm/pull/2202
STORM-2623: Add in a whitelist for scheduler strategies
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/knusbaum/incubator-storm STORM-2623
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2202.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2202
----
commit eabfa7df94c22a6e1842a6d3bf3fdc9f345850dc
Author: Kyle Nusbaum <kn...@yahoo-inc.com>
Date: 2017-07-10T21:30:22Z
Adding whitelist for scheduler strategies
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2202: STORM-2623: Add in a whitelist for scheduler strategies
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2202
@HeartSaVioR @kishorvpatil Please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2202: STORM-2623: Add in a whitelist for scheduler strategies
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2202
@knusbaum Kindly reminder.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2202: STORM-2623: Add in a whitelist for scheduler strategies
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2202
@knusbaum I guess it's messed up while squashing. Could you sort it out? If commit eabfa7d is clean one please let me know that I can just cherry pick it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2202: STORM-2623: Add in a whitelist for scheduler strat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2202
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2202: STORM-2623: Add in a whitelist for scheduler strategies
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the issue:
https://github.com/apache/storm/pull/2202
@HeartSaVioR Sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2202: STORM-2623: Add in a whitelist for scheduler strategies
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2202
+1
@knusbaum If you don't mind I'd like to request squashing commits into one since it's fairly small change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2202: STORM-2623: Add in a whitelist for scheduler strategies
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2202
@knusbaum Sorry now there's also tiny merge conflict. Could you also address this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2202: STORM-2623: Add in a whitelist for scheduler strat...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2202#discussion_r130254446
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ReflectionUtils.java ---
@@ -72,6 +74,17 @@ public static ReflectionUtils setInstance(ReflectionUtils u) {
}
}
+ public static <T> T newSchedulerStrategyInstance(String klass, Map<String, Object> conf) {
+ List<String> allowedSchedulerStrategies = (List<String>) conf.get(Config.NIMBUS_SCHEDULER_STRATEGY_CLASS_WHITELIST);
+ if(allowedSchedulerStrategies == null || allowedSchedulerStrategies.contains(klass)) {
+ return newInstance(klass);
+ }
+ else {
+ //throw new RuntimeException("Cannot run topology with strategy [" + klass + "]. Allowed strategies are: " + allowedSchedulerStrategies);
--- End diff --
Nit: Better to remove comment here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---