You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by tripodsan <gi...@git.apache.org> on 2014/04/24 01:43:43 UTC
[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX
GitHub user tripodsan opened a pull request:
https://github.com/apache/cordova-cli/pull/170
CB-6506 RTC: Add support for OSX
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tripodsan/cordova-cli CB-6506
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-cli/pull/170.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #170
----
commit 2b6a59772674f30ebfe25e3fd5f386bb6275782d
Author: Tobias Bocanegra <tr...@adobe.com>
Date: 2014-04-21T04:54:32Z
CB-6506 RTC: Add support for OSX
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-cli/pull/170#issuecomment-41448489
I think you should tag the OSX repo so that platforms.js can point to some 'known to work' version if it, and not just to 'master'
master is the bleeding edge, and future changes could break cli functionality.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX
Posted by Jesse <pu...@gmail.com>.
I have deleted the root VERSION file, however, the tag will remain where it
is.
@purplecabbage
risingj.com
On Mon, Apr 28, 2014 at 2:14 PM, Jesse <pu...@gmail.com> wrote:
> It probably makes more sense to delete the one I just added, as
> consistency with iOS is probably the first priority.
>
> @purplecabbage
> risingj.com
>
>
> On Mon, Apr 28, 2014 at 2:08 PM, tripodsan <gi...@git.apache.org> wrote:
>
>> Github user tripodsan commented on the pull request:
>>
>> https://github.com/apache/cordova-cli/pull/170#issuecomment-41613750
>>
>> makes sense. I'll (re)move the one in CordovaLib later, and fixup the
>> respective scripts
>> see https://issues.apache.org/jira/browse/CB-6541
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have
>> your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>>
>
>
Re: [GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX
Posted by Jesse <pu...@gmail.com>.
It probably makes more sense to delete the one I just added, as consistency
with iOS is probably the first priority.
@purplecabbage
risingj.com
On Mon, Apr 28, 2014 at 2:08 PM, tripodsan <gi...@git.apache.org> wrote:
> Github user tripodsan commented on the pull request:
>
> https://github.com/apache/cordova-cli/pull/170#issuecomment-41613750
>
> makes sense. I'll (re)move the one in CordovaLib later, and fixup the
> respective scripts
> see https://issues.apache.org/jira/browse/CB-6541
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX
Posted by tripodsan <gi...@git.apache.org>.
Github user tripodsan commented on the pull request:
https://github.com/apache/cordova-cli/pull/170#issuecomment-41613750
makes sense. I'll (re)move the one in CordovaLib later, and fixup the respective scripts
see https://issues.apache.org/jira/browse/CB-6541
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-cli/pull/170#issuecomment-41341461
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-cli/pull/170#issuecomment-41590320
From @shepheb on the mailing list:
"LGTM. There might be some reason we can't use identical flows for OSX and
iOS, but there's no point in having duplicate branches to the code if
they're the same right now. They can be split later if they diverge."
Thread: http://callback-dev.markmail.org/thread/3k45ht6lobxgeh5z
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX
Posted by tripodsan <gi...@git.apache.org>.
Github user tripodsan commented on the pull request:
https://github.com/apache/cordova-cli/pull/170#issuecomment-41460127
@purplecabbage thanks for the tip!
however, I don't have commit rights, so can you tag the latest cordova-osx commit https://github.com/apache/cordova-osx/commit/bbbd3cfdafd7bfee5c364957d32a8161aba5fefb with something meaning full, eg 3.5.0-RC1 ? then I can update the pull request. but I think this should be aligned with the `VERSION` file, right?
thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX
Posted by tripodsan <gi...@git.apache.org>.
Github user tripodsan commented on the pull request:
https://github.com/apache/cordova-cli/pull/170#issuecomment-41612738
thanks @purplecabbage. there is already a `VERSION` file in the `CordovaLib` directory. do we need both?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-cli/pull/170#issuecomment-41610058
I have added a VERSION file and tagged 3.5.0-dev
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-cli/pull/170
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-cli/pull/170#issuecomment-41613278
yes, I see that now. Do not need both, although I am a little confused why
iOS + OSX both have them in a lib folder while every other platform has it
at the repo/platform root.
@purplecabbage
risingj.com
On Mon, Apr 28, 2014 at 1:58 PM, Tobias Bocanegra
<no...@github.com>wrote:
> thanks @purplecabbage <https://github.com/purplecabbage>. there is
> already a VERSION file in the CordovaLib directory. do we need both?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/apache/cordova-cli/pull/170#issuecomment-41612738>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---