[jira] [Comment Edited] (MESOS-2633) Move implementations of Framework struct functions out of master.hpp

["Marco Massenzio (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548291#comment-14548291 ] 

Marco Massenzio edited comment on MESOS-2633 at 5/18/15 5:03 PM:
-----------------------------------------------------------------

This was eventually suggested as the best way forward:
{quote}
Per the offline discussion, how about we create a master/framework.hpp (and master/slave.hpp later), much like we did for master/metrics.hpp? Having definitions in master.hpp that are defined in framework.cpp is a bit unintuitive (I've seen a number of people get confused about this approach in master/http.cpp).

Note that originally a master/metrics.cpp file was added on the assumption that it would speed up build times, which likely didn't hold. Since you didn't find a compile time decrease from the current approach, I'd suggest just keeping all the code together in a master/framework.hpp header. Note also that this lets you forward declare 'Framework'.
{quote}
The original review has been discarded and a new one will be created.


was (Author: marco-mesos):
This was eventually suggested the best way forward:
{quote}
Per the offline discussion, how about we create a master/framework.hpp (and master/slave.hpp later), much like we did for master/metrics.hpp? Having definitions in master.hpp that are defined in framework.cpp is a bit unintuitive (I've seen a number of people get confused about this approach in master/http.cpp).

Note that originally a master/metrics.cpp file was added on the assumption that it would speed up build times, which likely didn't hold. Since you didn't find a compile time decrease from the current approach, I'd suggest just keeping all the code together in a master/framework.hpp header. Note also that this lets you forward declare 'Framework'.
{quote}
The original review has been discarded and a new one will be created.

> Move implementations of Framework struct functions out of master.hpp
> --------------------------------------------------------------------
>
>                 Key: MESOS-2633
>                 URL: https://issues.apache.org/jira/browse/MESOS-2633
>             Project: Mesos
>          Issue Type: Task
>          Components: master
>            Reporter: Joris Van Remoortere
>            Assignee: Marco Massenzio
>            Priority: Trivial
>              Labels: beginner, master, tech-debt, trivial
>
> To help reduce compile time and keep the header easy to read, let's move the implementations of the Framework struct functions out of master.hpp



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)