You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/20 03:04:42 UTC
[GitHub] [incubator-nuttx] yamt opened a new pull request #2347: Enable format check for syslog
yamt opened a new pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347
## Summary
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #2347: Enable format check for syslog
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#issuecomment-787538226
@fjpanag you can fix those formats. or you can give me your kconfig and let me fix it for you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2347: Enable format check for syslog
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#issuecomment-788855571
I am fine with either approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] fjpanag commented on pull request #2347: Enable format check for syslog
Posted by GitBox <gi...@apache.org>.
fjpanag commented on pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#issuecomment-787505848
@yamt @xiaoxiang781216
This effectively broke NuttX for me.
After this I am no longer able to build NuttX with `-Wall -Werror`, as I was before.
I get a bunch of similar errors:
```
In file included from /path/to/nuttx/include/nuttx/mm/shm.h:30,
from /path/to/nuttx/include/nuttx/sched.h:41,
from /path/to/nuttx/include/sched.h:36,
from /path/to/nuttx/include/nuttx/arch.h:81,
from chip/stm32_wwdg.c:41:
chip/stm32_wwdg.c: In function 'stm32_getstatus':
chip/stm32_wwdg.c:474:10: error: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
474 | wdinfo(" flags : %08x\n", status->flags);
| ^~~~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~
| |
| uint32_t {aka long unsigned int}
chip/stm32_wwdg.c:474:27: note: format string is defined here
474 | wdinfo(" flags : %08x\n", status->flags);
| ~~~^
| |
| unsigned int
| %08lx
In file included from /path/to/nuttx/include/nuttx/mm/shm.h:30,
from /path/to/nuttx/include/nuttx/sched.h:41,
from /path/to/nuttx/include/sched.h:36,
from /path/to/nuttx/include/nuttx/arch.h:81,
from chip/stm32_wwdg.c:41:
chip/stm32_wwdg.c:475:10: error: format '%d' expects argument of type 'int', but argument 3 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
475 | wdinfo(" timeout : %d\n", status->timeout);
| ^~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~
| |
| uint32_t {aka long unsigned int}
chip/stm32_wwdg.c:475:25: note: format string is defined here
475 | wdinfo(" timeout : %d\n", status->timeout);
| ~^
| |
| int
| %ld
In file included from /path/to/nuttx/include/nuttx/mm/shm.h:30,
from /path/to/nuttx/include/nuttx/sched.h:41,
from /path/to/nuttx/include/sched.h:36,
from /path/to/nuttx/include/nuttx/arch.h:81,
from chip/stm32_wwdg.c:41:
chip/stm32_wwdg.c:476:10: error: format '%d' expects argument of type 'int', but argument 3 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
476 | wdinfo(" timeleft : %d\n", status->flags);
| ^~~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~
| |
| uint32_t {aka long unsigned int}
chip/stm32_wwdg.c:476:25: note: format string is defined here
476 | wdinfo(" timeleft : %d\n", status->flags);
| ~^
| |
| int
| %ld
In file included from /path/to/nuttx/include/nuttx/mm/shm.h:30,
from /path/to/nuttx/include/nuttx/sched.h:41,
from /path/to/nuttx/include/sched.h:36,
from /path/to/nuttx/include/nuttx/arch.h:81,
from chip/stm32_wwdg.c:41:
chip/stm32_wwdg.c: In function 'stm32_settimeout':
CC: pthread/pthread_mutextrylock.c
chip/stm32_wwdg.c:506:10: error: format '%d' expects argument of type 'int', but argument 3 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
506 | wdinfo("Entry: timeout=%d\n", timeout);
| ^~~~~~~~~~~~~~~~~~~~~ ~~~~~~~
| |
| uint32_t {aka long unsigned int}
chip/stm32_wwdg.c:506:27: note: format string is defined here
506 | wdinfo("Entry: timeout=%d\n", timeout);
| ~^
| |
| int
| %ld
In file included from /path/to/nuttx/include/nuttx/mm/shm.h:30,
from /path/to/nuttx/include/nuttx/sched.h:41,
from /path/to/nuttx/include/sched.h:36,
from /path/to/nuttx/include/nuttx/arch.h:81,
from chip/stm32_wwdg.c:41:
chip/stm32_wwdg.c:512:13: error: format '%d' expects argument of type 'int', but argument 3 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
512 | wderr("ERROR: Cannot represent timeout=%d > %d\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
513 | timeout, WWDG_MAXTIMEOUT);
| ~~~~~~~
| |
| uint32_t {aka long unsigned int}
chip/stm32_wwdg.c:512:47: note: format string is defined here
512 | wderr("ERROR: Cannot represent timeout=%d > %d\n",
| ~^
| |
| int
| %ld
In file included from /path/to/nuttx/include/nuttx/mm/shm.h:30,
from /path/to/nuttx/include/nuttx/sched.h:41,
from /path/to/nuttx/include/sched.h:36,
from /path/to/nuttx/include/nuttx/arch.h:81,
from chip/stm32_wwdg.c:41:
chip/stm32_wwdg.c:512:13: error: format '%d' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Werror=format=]
512 | wderr("ERROR: Cannot represent timeout=%d > %d\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chip/stm32_wwdg.c:512:52: note: format string is defined here
512 | wderr("ERROR: Cannot represent timeout=%d > %d\n",
| ~^
| |
| int
| %ld
In file included from /path/to/nuttx/include/nuttx/mm/shm.h:30,
from /path/to/nuttx/include/nuttx/sched.h:41,
from /path/to/nuttx/include/sched.h:36,
from /path/to/nuttx/include/nuttx/arch.h:81,
from chip/stm32_wwdg.c:41:
chip/stm32_wwdg.c:594:10: error: format '%d' expects argument of type 'int', but argument 4 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
594 | wdinfo("wdgtb=%d fwwdg=%d reload=%d timeout=%d\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
595 | wdgtb, fwwdg, reload, priv->timeout);
| ~~~~~
| |
| uint32_t {aka long unsigned int}
chip/stm32_wwdg.c:594:27: note: format string is defined here
594 | wdinfo("wdgtb=%d fwwdg=%d reload=%d timeout=%d\n",
| ~^
| |
| int
| %ld
In file included from /path/to/nuttx/include/nuttx/mm/shm.h:30,
from /path/to/nuttx/include/nuttx/sched.h:41,
from /path/to/nuttx/include/sched.h:36,
from /path/to/nuttx/include/nuttx/arch.h:81,
from chip/stm32_wwdg.c:41:
chip/stm32_wwdg.c:594:10: error: format '%d' expects argument of type 'int', but argument 5 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
594 | wdinfo("wdgtb=%d fwwdg=%d reload=%d timeout=%d\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
595 | wdgtb, fwwdg, reload, priv->timeout);
| ~~~~~~
| |
| uint32_t {aka long unsigned int}
chip/stm32_wwdg.c:594:37: note: format string is defined here
594 | wdinfo("wdgtb=%d fwwdg=%d reload=%d timeout=%d\n",
| ~^
| |
| int
| %ld
In file included from /path/to/nuttx/include/nuttx/mm/shm.h:30,
from /path/to/nuttx/include/nuttx/sched.h:41,
from /path/to/nuttx/include/sched.h:36,
from /path/to/nuttx/include/nuttx/arch.h:81,
from chip/stm32_wwdg.c:41:
chip/stm32_wwdg.c:594:10: error: format '%d' expects argument of type 'int', but argument 6 has type 'uint32_t' {aka 'long unsigned int'} [-Werror=format=]
594 | wdinfo("wdgtb=%d fwwdg=%d reload=%d timeout=%d\n",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
595 | wdgtb, fwwdg, reload, priv->timeout);
| ~~~~~~~~~~~~~
| |
| uint32_t {aka long unsigned int}
chip/stm32_wwdg.c:594:48: note: format string is defined here
594 | wdinfo("wdgtb=%d fwwdg=%d reload=%d timeout=%d\n",
| ~^
| |
| int
|
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2347: Enable format check for syslog
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#issuecomment-730835091
@yamt we need add sysloglike to _none too, so the more mismatch can be exposured.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2347: Enable format check for syslog
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#discussion_r530955923
##########
File path: drivers/lcd/st7567.c
##########
@@ -729,7 +729,9 @@ static int st7567_getpower(struct lcd_dev_s *dev)
{
struct st7567_dev_s *priv = (struct st7567_dev_s *)dev;
DEBUGASSERT(priv);
- ginfo("powered: %s\n", st7567_powerstring(priv->powered));
+
+ /* ginfo("powered: %s\n", st7567_powerstring(priv->powered)); */
Review comment:
done
##########
File path: fs/spiffs/src/spiffs_core.c
##########
@@ -1534,8 +1534,10 @@ void spiffs_fobj_event(FAR struct spiffs_s *fs,
FAR struct spiffs_file_s *next;
int16_t objid = objid_raw & ~SPIFFS_OBJID_NDXFLAG;
+#ifdef CONFIG_DEBUG_FS_INFO
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2347: Enable format check for syslog
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#discussion_r530856506
##########
File path: drivers/lcd/st7567.c
##########
@@ -729,7 +729,9 @@ static int st7567_getpower(struct lcd_dev_s *dev)
{
struct st7567_dev_s *priv = (struct st7567_dev_s *)dev;
DEBUGASSERT(priv);
- ginfo("powered: %s\n", st7567_powerstring(priv->powered));
+
+ /* ginfo("powered: %s\n", st7567_powerstring(priv->powered)); */
Review comment:
Since the code can't compile, it's better to remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on pull request #2347: Enable format check for syslog
Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#issuecomment-730949096
> @yamt we need add sysloglike to _none too, so the more mismatch can be exposured:
> https://github.com/apache/incubator-nuttx/blob/master/include/debug.h#L107-L111
_none is a macro. and i don't think the attribute can be added to macros.
i guess it isn't acceptable to make _none a function as the idea of the macro is to eliminate it at compile time.
an inline function might be a solution. but i suspect it's controversial. i'm not sure if it can be optimized out cleanly as a macro either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2347: Enable format check for syslog
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#discussion_r527476356
##########
File path: include/nuttx/compiler.h
##########
@@ -144,6 +144,7 @@
# define noinline_function __attribute__ ((noinline))
# define printflike(a, b) __attribute__((__format__ (__printf__, a, b)))
+# define sysloglike(a, b) __attribute__((__format__ (__printf__, a, b)))
Review comment:
i separated them because syslog is not quite printf.
the implementations in gcc/clang might or might not need to distinguish them. (i guess not. but i dunno.)
anyway the separation makes the intention clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] fjpanag commented on pull request #2347: Enable format check for syslog
Posted by GitBox <gi...@apache.org>.
fjpanag commented on pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#issuecomment-788829816
@yamt I fixed those in #2951.
Nevertheless, I just wanted you to know. I didn't dig into the details of this PR, so maybe you know if this is expected side-effect?
@xiaoxiang781216 I would like to mess with the default defconfigs. It may have other side-effects in other places?
Maybe we can create a dummy defconfig for every chip, that has everything enabled? Just for the CI, so it can catch such errors?
Or generally a dummy board for every chip, that supposedly supports as much as options as possible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2347: Enable format check for syslog
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#discussion_r530855603
##########
File path: fs/spiffs/src/spiffs_core.c
##########
@@ -1534,8 +1534,10 @@ void spiffs_fobj_event(FAR struct spiffs_s *fs,
FAR struct spiffs_file_s *next;
int16_t objid = objid_raw & ~SPIFFS_OBJID_NDXFLAG;
+#ifdef CONFIG_DEBUG_FS_INFO
Review comment:
how about remove the CONFIG_DEBUG_FS_INFO check at line 1526? since many other similar place normally remove the check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2347: Enable format check for syslog
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#discussion_r530844304
##########
File path: fs/spiffs/src/spiffs_core.c
##########
@@ -1534,8 +1534,10 @@ void spiffs_fobj_event(FAR struct spiffs_s *fs,
FAR struct spiffs_file_s *next;
int16_t objid = objid_raw & ~SPIFFS_OBJID_NDXFLAG;
+#ifdef CONFIG_DEBUG_FS_INFO
Review comment:
to match the above variable declaration.
##########
File path: arch/x86_64/src/common/up_assert.c
##########
@@ -250,7 +250,7 @@ void up_assert(const char *filename, int lineno)
board_autoled_on(LED_ASSERTION);
-#if CONFIG_TASK_NAME_SIZE > 0
+#if CONFIG_TASK_NAME_SIZE > 0 && defined(CONFIG_DEBUG_ALERT)
Review comment:
to match the above variable declaration.
##########
File path: drivers/lcd/st7567.c
##########
@@ -729,7 +729,9 @@ static int st7567_getpower(struct lcd_dev_s *dev)
{
struct st7567_dev_s *priv = (struct st7567_dev_s *)dev;
DEBUGASSERT(priv);
- ginfo("powered: %s\n", st7567_powerstring(priv->powered));
+
+ /* ginfo("powered: %s\n", st7567_powerstring(priv->powered)); */
Review comment:
i have no strong opinion either ways.
##########
File path: drivers/lcd/st7567.c
##########
@@ -747,8 +749,10 @@ static int st7567_setpower(struct lcd_dev_s *dev, int power)
struct st7567_dev_s *priv = (struct st7567_dev_s *)dev;
DEBUGASSERT(priv && (unsigned)power <= CONFIG_LCD_MAXPOWER);
- ginfo("power: %s powered: %s\n",
- st7567_powerstring(power), st7567_powerstring(priv->powered));
+
+ /* ginfo("power: %s powered: %s\n",
Review comment:
i have no strong opinion either ways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2347: Enable format check for syslog
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#issuecomment-730952853
maybe we can define _none to:
do
{
if (0)
__arch_syslog(...);
} while(0)
like what others done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2347: Enable format check for syslog
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#issuecomment-730835091
@yamt we need add sysloglike to _none too, so the more mismatch can be exposured:
https://github.com/apache/incubator-nuttx/blob/master/include/debug.h#L107-L111
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2347: Enable format check for syslog
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2347: Enable format check for syslog
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#discussion_r530761629
##########
File path: fs/spiffs/src/spiffs_core.c
##########
@@ -1534,8 +1534,10 @@ void spiffs_fobj_event(FAR struct spiffs_s *fs,
FAR struct spiffs_file_s *next;
int16_t objid = objid_raw & ~SPIFFS_OBJID_NDXFLAG;
+#ifdef CONFIG_DEBUG_FS_INFO
Review comment:
why need add ifdef?
##########
File path: arch/x86_64/src/common/up_assert.c
##########
@@ -250,7 +250,7 @@ void up_assert(const char *filename, int lineno)
board_autoled_on(LED_ASSERTION);
-#if CONFIG_TASK_NAME_SIZE > 0
+#if CONFIG_TASK_NAME_SIZE > 0 && defined(CONFIG_DEBUG_ALERT)
Review comment:
why need check CONFIG_DEBUG_ALERT additionally?
##########
File path: drivers/lcd/st7567.c
##########
@@ -747,8 +749,10 @@ static int st7567_setpower(struct lcd_dev_s *dev, int power)
struct st7567_dev_s *priv = (struct st7567_dev_s *)dev;
DEBUGASSERT(priv && (unsigned)power <= CONFIG_LCD_MAXPOWER);
- ginfo("power: %s powered: %s\n",
- st7567_powerstring(power), st7567_powerstring(priv->powered));
+
+ /* ginfo("power: %s powered: %s\n",
Review comment:
should we remove it directly?
##########
File path: drivers/lcd/st7567.c
##########
@@ -729,7 +729,9 @@ static int st7567_getpower(struct lcd_dev_s *dev)
{
struct st7567_dev_s *priv = (struct st7567_dev_s *)dev;
DEBUGASSERT(priv);
- ginfo("powered: %s\n", st7567_powerstring(priv->powered));
+
+ /* ginfo("powered: %s\n", st7567_powerstring(priv->powered)); */
Review comment:
should we remove it directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2347: Enable format check for syslog
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#issuecomment-730835091
@yamt we need add sysloglike to _none too, so the more mismatch can be exposured:
https://github.com/apache/incubator-nuttx/blob/master/include/debug.h#L108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2347: Enable format check for syslog
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#discussion_r527379943
##########
File path: include/nuttx/compiler.h
##########
@@ -144,6 +144,7 @@
# define noinline_function __attribute__ ((noinline))
# define printflike(a, b) __attribute__((__format__ (__printf__, a, b)))
+# define sysloglike(a, b) __attribute__((__format__ (__printf__, a, b)))
Review comment:
should we reuse printflike macro?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2347: Enable format check for syslog
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2347:
URL: https://github.com/apache/incubator-nuttx/pull/2347#issuecomment-787591671
@fjpanag it's better to enable wwdg in some defconfig to catch the similar problem in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org