You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/11/20 08:49:53 UTC

[GitHub] [iceberg] zhangjun0x01 opened a new issue #1791: add list partitions for flinkcatalog

zhangjun0x01 opened a new issue #1791:
URL: https://github.com/apache/iceberg/issues/1791


   show partitions of table is very common required,I think we should add the funtions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] zhangjun0x01 commented on issue #1791: add list partitions for flinkcatalog

Posted by GitBox <gi...@apache.org>.
zhangjun0x01 commented on issue #1791:
URL: https://github.com/apache/iceberg/issues/1791#issuecomment-732762830


   In the first PR, I currently only implement the first method `listPartitions(ObjectPath tablePath)`.
   
    the `listPartitions(ObjectPath tablePath, CatalogPartitionSpec partitionSpec)` method requires a CatalogPartitionSpec parameter, and the type of the `CatalogPartitionSpec#partitionSpec `  is Map<String, String>. I tested it, the filter in iceberg needs to match the value and type.
   For example, if the partition type is int, we need to pass  `123`. pass `"123"` is wrong, so I think we may need to improve the CatalogPartitionSpec#partitionSpec of flink to Map<String, Object> so that  more  compatibility 
   
     The `listPartitionsByFilter(ObjectPath tablePath, List<Expression> filters)` method need to transform the expression of flink to the expression of iceberg. I think it will also need a lot of work.
   
     So I think we can implement the first method first, and then implement the other two methods in sub-PR later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] openinx closed issue #1791: add list partitions for flinkcatalog

Posted by GitBox <gi...@apache.org>.
openinx closed issue #1791:
URL: https://github.com/apache/iceberg/issues/1791


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] openinx commented on issue #1791: add list partitions for flinkcatalog

Posted by GitBox <gi...@apache.org>.
openinx commented on issue #1791:
URL: https://github.com/apache/iceberg/issues/1791#issuecomment-731148555


   Sounds good to me, we might need to implement those methods in `FlinkCatalog`: 
   
   ```java
     @Override
     public List<CatalogPartitionSpec> listPartitions(ObjectPath tablePath)
         throws CatalogException {
       throw new UnsupportedOperationException();
     }
   
     @Override
     public List<CatalogPartitionSpec> listPartitions(ObjectPath tablePath, CatalogPartitionSpec partitionSpec)
         throws CatalogException {
       throw new UnsupportedOperationException();
     }
   
     @Override
     public List<CatalogPartitionSpec> listPartitionsByFilter(ObjectPath tablePath, List<Expression> filters)
         throws CatalogException {
       throw new UnsupportedOperationException();
     }
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org