You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by "amoeba (via GitHub)" <gi...@apache.org> on 2025/08/20 17:19:58 UTC
[PR] MINOR: [Website] Fix anchors on visual identity page [arrow-site]
amoeba opened a new pull request, #696:
URL: https://github.com/apache/arrow-site/pull/696
I think the recent markdown parser change made it so we can't do headers like this anymore,
```
# Design of the logo {#design}
```
This fixes the [current rendering](https://arrow.apache.org/visual_identity/) of:
> Design of the logo {#design}
and restores the internal document anchors. A better solution might be to look into a Jekyll plugin that automatically enables anchors on headers and ToCs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Website] Fix anchors on visual identity page [arrow-site]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #696:
URL: https://github.com/apache/arrow-site/pull/696#issuecomment-3207363813
Preview URL: https://amoeba.github.io/arrow-site
If the preview URL doesn't work, you may forget to configure your fork repository for preview.
See https://github.com/apache/arrow-site/blob/main/README.md#forks how to configure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-695: [Website] Fix anchors on visual identity page [arrow-site]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on code in PR #696:
URL: https://github.com/apache/arrow-site/pull/696#discussion_r2291681698
##########
visual_identity.md:
##########
@@ -32,7 +32,9 @@ As a community project, the visual identity guidelines for Apache Arrow attempt
- [Usage guidelines](#using-the-logo)
- [List of logo files](#files)
-## Design of the logo {#design}
+<a name="design">
Review Comment:
You're right. Done in c6f0ec3f4c0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Website] Fix anchors on visual identity page [arrow-site]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #696:
URL: https://github.com/apache/arrow-site/pull/696#issuecomment-3208430861
Kou filed https://github.com/apache/arrow-site/issues/695 for this, yeah
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Website] Fix anchors on visual identity page [arrow-site]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #696:
URL: https://github.com/apache/arrow-site/pull/696#discussion_r2289662846
##########
visual_identity.md:
##########
@@ -32,7 +32,9 @@ As a community project, the visual identity guidelines for Apache Arrow attempt
- [Usage guidelines](#using-the-logo)
- [List of logo files](#files)
-## Design of the logo {#design}
+<a name="design">
Review Comment:
Could you add a close tag explicitly?
```suggestion
<a name="design"></a>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-695: [Website] Fix anchors on visual identity page [arrow-site]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba merged PR #696:
URL: https://github.com/apache/arrow-site/pull/696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Website] Fix anchors on visual identity page [arrow-site]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #696:
URL: https://github.com/apache/arrow-site/pull/696#issuecomment-3208497193
> Kou filed https://github.com/apache/arrow-site/issues/695 for this, yeah
Thanks, I missed that. I grepped for `{#` and didn't see other uses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org