You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wu-sheng (via GitHub)" <gi...@apache.org> on 2024/08/06 14:44:04 UTC
[I] [BanyanDB] Package ctl binary separatedly. [skywalking]
wu-sheng opened a new issue, #12510:
URL: https://github.com/apache/skywalking/issues/12510
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
DB ctl tool is included in server binary and image, which is not convenient and easier to trggier cli.
### Use case
We should package ctl out of database server binary with signed asc and sha code.
Then, from the experience of OAP, we should not include ctl in the server image too.
### Related issues
_No response_
### Are you willing to submit a pull request to implement this on your own?
- [ ] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BanyanDB] Package ctl binary separatedly. [skywalking]
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily commented on issue #12510:
URL: https://github.com/apache/skywalking/issues/12510#issuecomment-2276819546
> Then, from the experience of OAP, we should not include ctl in the server image too.
The health-checking procedure depends on bydbctl to check the health of HTTP and gRPC services. Should we add a bydbctl sidecar to each node? What are your main concerns about incorporating bydbctl?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BanyanDB] Package ctl binary separatedly. [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed issue #12510: [BanyanDB] Package ctl binary separatedly.
URL: https://github.com/apache/skywalking/issues/12510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BanyanDB] Package ctl binary separatedly. [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #12510:
URL: https://github.com/apache/skywalking/issues/12510#issuecomment-2277167625
Recently, we add simply http endpoint in OAP for health check to simplify this case.
You should consider that too. Rely on ctl Makes things tricky.
https://skywalking.apache.org/docs/main/next/en/api/health-check/
For k8s, we don't need that complex and complete health check. It should be simply true or false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BanyanDB] Package ctl binary separatedly. [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #12510:
URL: https://github.com/apache/skywalking/issues/12510#issuecomment-2277181844
> What are your main concerns about incorporating bydbctl?
- Lower cve maintenance in deployment. Less is better from my past years experiences.
- Healthy check should be easy and to be done through http endpoint. It limits features, but k8s pod check doesn't need those. We will be able to use ctl when we need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org