You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/10/22 06:09:01 UTC
[kudu-CR] [common] introduce TxnId wrapper
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16624
Change subject: [common] introduce TxnId wrapper
......................................................................
[common] introduce TxnId wrapper
TxnId is a wrapper around int64_t with transaction-related
specifics. It's an alternative to boost::optional<int64_t> since
it lightweight and it's possible to use it as an atomic
(i.e. std::atomic<TxnId> works as expected).
This patch also contains appropriate test coverage for the newly
introduced functionality.
Change-Id: I0511637702e946f140dc617ee6bf7e1c3d5289e3
---
M src/kudu/common/CMakeLists.txt
A src/kudu/common/txn_id-test.cc
A src/kudu/common/txn_id.cc
A src/kudu/common/txn_id.h
4 files changed, 219 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/24/16624/1
--
To view, visit http://gerrit.cloudera.org:8080/16624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0511637702e946f140dc617ee6bf7e1c3d5289e3
Gerrit-Change-Number: 16624
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [common] introduce TxnId wrapper
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16624 )
Change subject: [common] introduce TxnId wrapper
......................................................................
[common] introduce TxnId wrapper
TxnId is a wrapper around int64_t with transaction-related
specifics. It's an alternative to boost::optional<int64_t> since
it lightweight and it's possible to use it as an atomic
(i.e. std::atomic<TxnId> works as expected).
This patch also contains appropriate test coverage for the newly
introduced functionality.
Change-Id: I0511637702e946f140dc617ee6bf7e1c3d5289e3
Reviewed-on: http://gerrit.cloudera.org:8080/16624
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/common/CMakeLists.txt
A src/kudu/common/txn_id-test.cc
A src/kudu/common/txn_id.cc
A src/kudu/common/txn_id.h
4 files changed, 219 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0511637702e946f140dc617ee6bf7e1c3d5289e3
Gerrit-Change-Number: 16624
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [common] introduce TxnId wrapper
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16624 )
Change subject: [common] introduce TxnId wrapper
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16624
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0511637702e946f140dc617ee6bf7e1c3d5289e3
Gerrit-Change-Number: 16624
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Thu, 22 Oct 2020 17:59:08 +0000
Gerrit-HasComments: No