You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "david-mollitor-db (via GitHub)" <gi...@apache.org> on 2026/09/17 14:27:21 UTC

[PR] [MINOR][GRAPHX] Remove unused arpack_combined_all dependency [spark]

david-mollitor-db opened a new pull request, #58891:
URL: https://github.com/apache/spark/pull/58891

   ### What changes were proposed in this pull request?
   
   This PR removes the `net.sourceforge.f2j:arpack_combined_all` (0.1) dependency
   from `graphx/pom.xml`, and drops the corresponding jar from the dependency
   manifest `dev/deps/spark-deps-hadoop-3-hive-2.3`.
   
   ### Why are the changes needed?
   
   GraphX declares `arpack_combined_all` but never references it:
   
   - GraphX has no eigenvalue-decomposition code. Its only netlib user,
     `SVDPlusPlus`, uses BLAS exclusively (`org.apache.spark.ml.linalg.BLAS`,
     backed by `dev.ludovic.netlib:blas`, which is retained). The only mentions of
     "arpack" in GraphX are comments in `PageRankSuite` referencing R's
     `page_rank(..., algo = "arpack")`, unrelated to this Java library.
   - ARPACK is used only by MLlib (`ARPACK`, `EigenValueDecomposition`,
     `RowMatrix`), which binds the modern `dev.ludovic.netlib:arpack` -- not the
     old F2J artifact.
   
   `arpack_combined_all` is a leftover from the old `com.github.fommil.netlib`
   era, before the migration to `dev.ludovic.netlib`. GraphX is the sole declarer
   of this artifact across the whole repository, so removing the declaration drops
   the jar from the classpath; the dependency manifest is updated to match.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   `mvn dependency:tree -pl graphx` confirms `net.sourceforge.f2j:arpack_combined_all`
   no longer resolves for GraphX while `dev.ludovic.netlib:blas` is retained.
   Existing CI (including `dev/test-dependencies.sh`, which validates the manifest)
   covers the change.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Isaac
   
   This pull request and its description were written by Isaac.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [MINOR][GRAPHX] Remove unused arpack_combined_all dependency [spark]

Posted by "david-mollitor-db (via GitHub)" <gi...@apache.org>.
david-mollitor-db closed pull request #58891: [MINOR][GRAPHX] Remove unused arpack_combined_all dependency
URL: https://github.com/apache/spark/pull/58891


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org