You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/03/01 10:54:09 UTC
[GitHub] [kylin] harveyyue opened a new pull request #1128: KYLIN-4389
Change Flink jar dependence from compile to provided
harveyyue opened a new pull request #1128: KYLIN-4389 Change Flink jar dependence from compile to provided
URL: https://github.com/apache/kylin/pull/1128
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] shaofengshi commented on issue #1128: KYLIN-4389 Change
Flink jar dependence from compile to provided
Posted by GitBox <gi...@apache.org>.
shaofengshi commented on issue #1128: KYLIN-4389 Change Flink jar dependence from compile to provided
URL: https://github.com/apache/kylin/pull/1128#issuecomment-593186130
Hi Harvey, the code change looks good to me; The only thing is, this PR contains 3 commits, and 2 of them are merge commits. As you know, merge commits are not acceptable. Could you please rebase and squash these commits as one? If you don't know how to do that, just feel free to let me know.
BTW, are you modifying code on master branch? If so, suggest you create another branch and then commit changes there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1128: KYLIN-4389 Change Flink
jar dependence from compile to provided
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1128: KYLIN-4389 Change Flink jar dependence from compile to provided
URL: https://github.com/apache/kylin/pull/1128#issuecomment-593085594
## Pull Request Test Coverage Report for [Build 5674](https://coveralls.io/builds/29054651)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* **3** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.001%**) to **27.526%**
---
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [server-base/src/main/java/org/apache/kylin/rest/util/QueryRequestLimits.java](https://coveralls.io/builds/29054651/source?filename=server-base%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Frest%2Futil%2FQueryRequestLimits.java#L72) | 1 | 47.62% |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/CheckPointStore.java](https://coveralls.io/builds/29054651/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2FCheckPointStore.java#L98) | 2 | 73.74% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/29054651) |
| :-- | --: |
| Change from base [Build 5670](https://coveralls.io/builds/29043776): | -0.001% |
| Covered Lines: | 24297 |
| Relevant Lines: | 88270 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] shaofengshi commented on issue #1128: KYLIN-4389 Change
Flink jar dependence from compile to provided
Posted by GitBox <gi...@apache.org>.
shaofengshi commented on issue #1128: KYLIN-4389 Change Flink jar dependence from compile to provided
URL: https://github.com/apache/kylin/pull/1128#issuecomment-593417995
New pr merged, this pr is not needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] shaofengshi closed pull request #1128: KYLIN-4389 Change
Flink jar dependence from compile to provided
Posted by GitBox <gi...@apache.org>.
shaofengshi closed pull request #1128: KYLIN-4389 Change Flink jar dependence from compile to provided
URL: https://github.com/apache/kylin/pull/1128
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services