You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "leizhiyuan (via GitHub)" <gi...@apache.org> on 2023/07/03 08:33:26 UTC
[GitHub] [rocketmq] leizhiyuan opened a new pull request, #6985: [ISSUE #6979] fix opaque will be duplicate in multi client scene
leizhiyuan opened a new pull request, #6985:
URL: https://github.com/apache/rocketmq/pull/6985
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Fixes #6979
### Brief Description
When two different clients request the same proxy, it is possible that their opaque values are the same. In this case, message repetition or message loss may occur.
### How Did You Test This Change?
just run case with multi consumers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] lizhimins merged pull request #6985: [ISSUE #6979] fix opaque will be duplicate in multi client scene
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #6985:
URL: https://github.com/apache/rocketmq/pull/6985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #6985: [ISSUE #6979] fix opaque will be duplicate in multi client scene
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6985:
URL: https://github.com/apache/rocketmq/pull/6985#issuecomment-1619398658
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/6985?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#6985](https://app.codecov.io/gh/apache/rocketmq/pull/6985?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8902f50) into [develop](https://app.codecov.io/gh/apache/rocketmq/commit/5c3bd98e50098caa5ad701d99f4cfffb65e69b3f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5c3bd98) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## develop #6985 +/- ##
=============================================
- Coverage 42.68% 42.68% -0.01%
+ Complexity 9236 9229 -7
=============================================
Files 1133 1133
Lines 80492 80500 +8
Branches 10515 10515
=============================================
- Hits 34362 34360 -2
- Misses 41834 41843 +9
- Partials 4296 4297 +1
```
| [Impacted Files](https://app.codecov.io/gh/apache/rocketmq/pull/6985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...tmq/proxy/processor/DefaultMessagingProcessor.java](https://app.codecov.io/gh/apache/rocketmq/pull/6985?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3Byb2Nlc3Nvci9EZWZhdWx0TWVzc2FnaW5nUHJvY2Vzc29yLmphdmE=) | `2.46% <0.00%> (-0.28%)` | :arrow_down: |
... and [19 files with indirect coverage changes](https://app.codecov.io/gh/apache/rocketmq/pull/6985/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org