You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "matheusbsilva (via GitHub)" <gi...@apache.org> on 2023/06/01 12:51:44 UTC
[GitHub] [superset] matheusbsilva opened a new pull request, #24263: [WIP] feat(formatters): Add custom d3-time-format locale
matheusbsilva opened a new pull request, #24263:
URL: https://github.com/apache/superset/pull/24263
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Adds a configuration option to change the default language of time related data on charts, including the option to translate months. This is related to issues: #3972 , https://github.com/apache/superset/issues/13442 and https://github.com/apache/superset/issues/17447.
During the implementation I had to change how the smart formatters were used across the application, because I had to ensure that they were instantiated with the right locale configuration. So instead of importing them directly, I got them through the TimeFormatterRegistry. I'm not sure if is the best option, let me know.
**PS: Currently WIP because I'm fixing the tests.**
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
Without time format configuration:
With brazilian portuguese time format configuration:
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
Add the `D3_TIME_FORMAT` with your locale configuration to `superset_config.py` following the definition expected by D3 ([docs](https://github.com/d3/d3-time-format/tree/main#locales)), for example, this is the definition for brazilian portuguese:
```py
D3_TIME_FORMAT = {
"dateTime": "%A, %e de %B de %Y. %X",
"date": "%d/%m/%Y",
"time": "%H:%M:%S",
"periods": ["AM", "PM"],
"days": ["Domingo", "Segunda", "Terça", "Quarta", "Quinta", "Sexta", "Sábado"],
"shortDays": ["Dom", "Seg", "Ter", "Qua", "Qui", "Sex", "Sáb"],
"months": ["Janeiro", "Fevereiro", "Março", "Abril", "Maio", "Junho", "Julho", "Agosto", "Setembro", "Outubro", "Novembro", "Dezembro"],
"shortMonths": ["Jan", "Fev", "Mar", "Abr", "Mai", "Jun", "Jul", "Ago", "Set", "Out", "Nov", "Dez"]
}
```
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [X] Has associated issue:
- [ ] Required feature flags:
- [X] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [X] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(formatters): Add custom d3-time-format locale [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-2033216389
Running CI. Fingers crossed! 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lf-floriandin commented on pull request #24263: feat(formatters): Add custom d3-time-format locale
Posted by "lf-floriandin (via GitHub)" <gi...@apache.org>.
lf-floriandin commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-1632095676
Oh big fan of this!
Any updates on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(formatters): Add custom d3-time-format locale [superset]
Posted by "matheusbsilva (via GitHub)" <gi...@apache.org>.
matheusbsilva commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-1774199798
@eschutho I fixed the conflicts. If there is anything that I can do to help with the review, let me know :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(formatters): Add custom d3-time-format locale [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-1979878494
Looks like this needs some linting AND a rebase at this point. If @matheusbsilva wants to follow through, that's awesome, but anyone else is also welcome to pick this up if they desire to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(formatters): Add custom d3-time-format locale [superset]
Posted by "matheusbsilva (via GitHub)" <gi...@apache.org>.
matheusbsilva commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-2061326830
@rusackas Is there anything else that I can do to help with the review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(formatters): Add custom d3-time-format locale [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-1745714193
@eschutho Container image not yet published for this PR. Please try again when build is complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #24263: feat(formatters): Add custom d3-time-format locale
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-1585187149
Also ccing @villebro since he is working on some other localization features.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(formatters): Add custom d3-time-format locale [superset]
Posted by "rtotheb2000 (via GitHub)" <gi...@apache.org>.
rtotheb2000 commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-1978120313
any updates on this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(formatters): Add custom d3-time-format locale [superset]
Posted by "eschutho (via GitHub)" <gi...@apache.org>.
eschutho commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-1745713225
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(formatters): Add custom d3-time-format locale [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-1745714212
@eschutho Ephemeral environment creation failed. Please check the Actions logs for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(formatters): Add custom d3-time-format locale [superset]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-2065471665
@rusackas Ephemeral environment spinning up at http://52.33.93.221:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cchristofr commented on pull request #24263: feat(formatters): Add custom d3-time-format locale
Posted by "cchristofr (via GitHub)" <gi...@apache.org>.
cchristofr commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-1732256968
Many thanks for this PR.
I'm awaiting for this PR: To use Superset in France (public sector), this PR is mandatory.
Do you have any idea when this PR will be merged in superset?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(formatters): Add custom d3-time-format locale [superset]
Posted by "cchristofr (via GitHub)" <gi...@apache.org>.
cchristofr commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-1773736882
up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] matheusbsilva commented on pull request #24263: feat(formatters): Add custom d3-time-format locale
Posted by "matheusbsilva (via GitHub)" <gi...@apache.org>.
matheusbsilva commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-1692283106
Any updates on this review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(formatters): Add custom d3-time-format locale [superset]
Posted by "matheusbsilva (via GitHub)" <gi...@apache.org>.
matheusbsilva commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-1980910519
Thansk for the reply @rusackas, I'll fix the linting errors soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Cmagno13 commented on pull request #24263: feat(formatters): Add custom d3-time-format locale
Posted by "Cmagno13 (via GitHub)" <gi...@apache.org>.
Cmagno13 commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-1693415483
Any updates on this review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24263: feat(formatters): Add custom d3-time-format locale
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-1572508987
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24263?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24263](https://app.codecov.io/gh/apache/superset/pull/24263?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (96ba70b) into [master](https://app.codecov.io/gh/apache/superset/commit/50535e427e51743e298d46009d51b08ef2380012?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (50535e4) will **decrease** coverage by `1.78%`.
> The diff coverage is `56.66%`.
> :exclamation: Current head 96ba70b differs from pull request most recent head e85c700. Consider uploading reports for the commit e85c700 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24263 +/- ##
==========================================
- Coverage 68.30% 66.53% -1.78%
==========================================
Files 1957 1954 -3
Lines 75594 75583 -11
Branches 8224 8216 -8
==========================================
- Hits 51637 50287 -1350
- Misses 21849 23191 +1342
+ Partials 2108 2105 -3
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `78.92% <100.00%> (+<0.01%)` | :arrow_up: |
| postgres | `79.00% <100.00%> (+<0.01%)` | :arrow_up: |
| presto | `?` | |
| python | `79.13% <100.00%> (-3.69%)` | :arrow_down: |
| sqlite | `77.54% <100.00%> (+<0.01%)` | :arrow_up: |
| unit | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...perset-ui-chart-controls/src/utils/D3Formatting.ts](https://app.codecov.io/gh/apache/superset/pull/24263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY2hhcnQtY29udHJvbHMvc3JjL3V0aWxzL0QzRm9ybWF0dGluZy50cw==) | `100.00% <ø> (ø)` | |
| [...t-ui-core/src/time-format/TimeFormatterRegistry.ts](https://app.codecov.io/gh/apache/superset/pull/24263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvVGltZUZvcm1hdHRlclJlZ2lzdHJ5LnRz) | `100.00% <ø> (ø)` | |
| [.../src/time-format/factories/createMultiFormatter.ts](https://app.codecov.io/gh/apache/superset/pull/24263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdGltZS1mb3JtYXQvZmFjdG9yaWVzL2NyZWF0ZU11bHRpRm9ybWF0dGVyLnRz) | `100.00% <ø> (ø)` | |
| [...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts](https://app.codecov.io/gh/apache/superset/pull/24263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGFja2FnZXMvc3VwZXJzZXQtdWktY29yZS9zcmMvdWktb3ZlcnJpZGVzL0V4dGVuc2lvbnNSZWdpc3RyeS50cw==) | `100.00% <ø> (ø)` | |
| [.../legacy-plugin-chart-pivot-table/src/PivotTable.js](https://app.codecov.io/gh/apache/superset/pull/24263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBpdm90LXRhYmxlL3NyYy9QaXZvdFRhYmxlLmpz) | `0.00% <ø> (ø)` | |
| [...nd/plugins/legacy-preset-chart-nvd3/src/NVD3Vis.js](https://app.codecov.io/gh/apache/superset/pull/24263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL05WRDNWaXMuanM=) | `0.00% <ø> (ø)` | |
| [...tend/plugins/legacy-preset-chart-nvd3/src/utils.js](https://app.codecov.io/gh/apache/superset/pull/24263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL3V0aWxzLmpz) | `15.38% <ø> (-0.54%)` | :arrow_down: |
| [...harts/src/BigNumber/BigNumberTotal/controlPanel.ts](https://app.codecov.io/gh/apache/superset/pull/24263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQmlnTnVtYmVyL0JpZ051bWJlclRvdGFsL2NvbnRyb2xQYW5lbC50cw==) | `30.00% <ø> (ø)` | |
| [...lugin-chart-echarts/src/BigNumber/BigNumberViz.tsx](https://app.codecov.io/gh/apache/superset/pull/24263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQmlnTnVtYmVyL0JpZ051bWJlclZpei50c3g=) | `0.00% <ø> (ø)` | |
| [.../BigNumber/BigNumberWithTrendline/controlPanel.tsx](https://app.codecov.io/gh/apache/superset/pull/24263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvQmlnTnVtYmVyL0JpZ051bWJlcldpdGhUcmVuZGxpbmUvY29udHJvbFBhbmVsLnRzeA==) | `16.66% <ø> (ø)` | |
| ... and [22 more](https://app.codecov.io/gh/apache/superset/pull/24263?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [94 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24263/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(formatters): Add custom d3-time-format locale [superset]
Posted by "matheusbsilva (via GitHub)" <gi...@apache.org>.
matheusbsilva commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-2034930876
@rusackas I added more tests to fix the [coverage issue](https://github.com/apache/superset/actions/runs/8473845643/job/23367969262?pr=24263) reported in the last CI run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(formatters): Add custom d3-time-format locale [superset]
Posted by "ImmortalLotus (via GitHub)" <gi...@apache.org>.
ImmortalLotus commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-1914686963
any updates on this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(formatters): Add custom d3-time-format locale [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-2065463428
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] feat(formatters): Add custom d3-time-format locale [superset]
Posted by "matheusbsilva (via GitHub)" <gi...@apache.org>.
matheusbsilva commented on PR #24263:
URL: https://github.com/apache/superset/pull/24263#issuecomment-2026163855
@rusackas I've fixed the linting errors and checked all the linters locally, everything is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org