You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2008/03/03 07:02:50 UTC

[jira] Created: (JCR-1445) [PATCH] Use entrySet iterators to avoid map look ups in loops

[PATCH] Use entrySet iterators to avoid map look ups in loops
-------------------------------------------------------------

                 Key: JCR-1445
                 URL: https://issues.apache.org/jira/browse/JCR-1445
             Project: Jackrabbit
          Issue Type: Improvement
          Components: jackrabbit-core
    Affects Versions: core 1.4.1
            Reporter: Dave Brosius
             Fix For: core 1.4.2
         Attachments: use_entry_sets.patch

Code uses a keySet iterator in a loop, then does a map look up using the key retrieved from the iterator. 

Might as well use an entrySet iterator to avoid n map lookups.

Patch does this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-1445) [PATCH] Use entrySet iterators to avoid map look ups in loops

Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Brosius updated JCR-1445:
------------------------------

    Priority: Trivial  (was: Major)

> [PATCH] Use entrySet iterators to avoid map look ups in loops
> -------------------------------------------------------------
>
>                 Key: JCR-1445
>                 URL: https://issues.apache.org/jira/browse/JCR-1445
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: core 1.4.1
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: core 1.4.2
>
>         Attachments: use_entry_sets.patch
>
>
> Code uses a keySet iterator in a loop, then does a map look up using the key retrieved from the iterator. 
> Might as well use an entrySet iterator to avoid n map lookups.
> Patch does this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-1445) [PATCH] Use entrySet iterators to avoid map look ups in loops

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting updated JCR-1445:
-------------------------------

    Affects Version/s:     (was: core 1.4.1)
        Fix Version/s:     (was: core 1.4.2)
                       1.5

> [PATCH] Use entrySet iterators to avoid map look ups in loops
> -------------------------------------------------------------
>
>                 Key: JCR-1445
>                 URL: https://issues.apache.org/jira/browse/JCR-1445
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: 1.5
>
>         Attachments: use_entry_sets.patch
>
>
> Code uses a keySet iterator in a loop, then does a map look up using the key retrieved from the iterator. 
> Might as well use an entrySet iterator to avoid n map lookups.
> Patch does this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (JCR-1445) [PATCH] Use entrySet iterators to avoid map look ups in loops

Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved JCR-1445.
--------------------------------

    Resolution: Fixed
      Assignee: Jukka Zitting

Patch applied in revision 691313. Thanks!

> [PATCH] Use entrySet iterators to avoid map look ups in loops
> -------------------------------------------------------------
>
>                 Key: JCR-1445
>                 URL: https://issues.apache.org/jira/browse/JCR-1445
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>            Reporter: Dave Brosius
>            Assignee: Jukka Zitting
>            Priority: Trivial
>             Fix For: 1.5
>
>         Attachments: use_entry_sets.patch
>
>
> Code uses a keySet iterator in a loop, then does a map look up using the key retrieved from the iterator. 
> Might as well use an entrySet iterator to avoid n map lookups.
> Patch does this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (JCR-1445) [PATCH] Use entrySet iterators to avoid map look ups in loops

Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JCR-1445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Brosius updated JCR-1445:
------------------------------

    Attachment: use_entry_sets.patch

> [PATCH] Use entrySet iterators to avoid map look ups in loops
> -------------------------------------------------------------
>
>                 Key: JCR-1445
>                 URL: https://issues.apache.org/jira/browse/JCR-1445
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: core 1.4.1
>            Reporter: Dave Brosius
>             Fix For: core 1.4.2
>
>         Attachments: use_entry_sets.patch
>
>
> Code uses a keySet iterator in a loop, then does a map look up using the key retrieved from the iterator. 
> Might as well use an entrySet iterator to avoid n map lookups.
> Patch does this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.