[GitHub] zhfeng commented on a change in pull request #119: SCB-233 update to deploy only with non PR building

[GitBox <gi...@apache.org>]

zhfeng commented on a change in pull request #119: SCB-233 update to deploy only with non PR building
URL: https://github.com/apache/incubator-servicecomb-saga/pull/119#discussion_r161449469
 
 

 ##########
 File path: .travis.yml
 ##########
 @@ -27,7 +27,7 @@ script:
 - mvn clean install -Pjacoco -Pdocker coveralls:report
 - mvn clean verify -f saga-demo -Pdemo -Pdocker -Ddocker.useColor=false -Ddocker.showLogs
 after_success:
-- mvn deploy -DskipTests --settings .travis.settings.xml
+- if [ "$TRAVIS_PULL_REQUEST" = "false" ]; then mvn deploy -DskipTests --settings .travis.settings.xml; fi
 
 Review comment:
   see http://docs.travis-ci.com/user/ci-environment/
   TRAVIS_BRANCH
   * for push builds, or builds not triggered by a pull request, this is the name of the branch.
   * for builds triggered by a pull request this is the name of the branch targeted by the pull request.
   * for builds triggered by a tag, this is the same as the name of the tag (TRAVIS_TAG).
   
   So it looks like in many case of the pull request, the branch target is "master". 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services