[GitHub] [flink-jira-bot] pnowojski commented on a change in pull request #23: [FLINK-23206] Minor tickets are moved to Not a Priority instead of cl…

[GitBox <gi...@apache.org>]

pnowojski commented on a change in pull request #23:
URL: https://github.com/apache/flink-jira-bot/pull/23#discussion_r678330115



##########
File path: flink_jira_bot.py
##########
@@ -65,14 +64,16 @@ def get_args():
     stale_assigned_rule = StaleAssignedRule(
         jira, jira_bot_config["stale_assigned"], args.dryrun
     )
-    stale_minor_rule = StaleMinorRule(jira, jira_bot_config["stale_minor"], args.dryrun)
-    stale_major_rule = StaleMajorOrAboveRule(
+    stale_minor_rule = StaleUnassignedRule(
+        jira, jira_bot_config["stale_minor"], args.dryrun, "Major", "Not a Priority"
+    )
+    stale_major_rule = StaleUnassignedRule(
         jira, jira_bot_config["stale_major"], args.dryrun, "Major", "Minor"
     )

Review comment:
       How is it supposed to be working? We have now two `StaleUnassignedRule`s, both from `Major` one to `Minor` other to `Not a Priority` at the same time?

##########
File path: stale_unassigned_rule.py
##########
@@ -20,7 +20,7 @@
 import logging
 
 
-class StaleMajorOrAboveRule(FlinkJiraRule):
+class StaleUnassignedRule(FlinkJiraRule):
     """
     Tickets major and above without a fixVersion need an assignee, or an update within {stale_<blocker|critical|major>.stale_days},

Review comment:
       nit: outdated comment `Tickets major and above`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org