[GitHub] [spark] Ngone51 commented on a change in pull request #27724: [SPARK-30973][SQL] ScriptTransformationExec should wait for the termination …

[GitBox <gi...@apache.org>]

Ngone51 commented on a change in pull request #27724: [SPARK-30973][SQL] ScriptTransformationExec should wait for the termination …
URL: https://github.com/apache/spark/pull/27724#discussion_r388068768
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformationExec.scala
 ##########
 @@ -161,6 +161,7 @@ case class ScriptTransformationExec(
 
               if (scriptOutputReader != null) {
                 if (scriptOutputReader.next(scriptOutputWritable) <= 0) {
 
 Review comment:
   Oh...I mean, is it possible that `scriptOutputReader.next` returns `<=0` but the process hang?
   If it's possible, we may need to destroy the process before `proc.waitFor()`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org