[GitHub] [spark] hdaikoku commented on a diff in pull request #42426: [SPARK-44756] Executor hangs when RetryingBlockTransferor fails to initiate retry

["hdaikoku (via GitHub)" <gi...@apache.org>]

hdaikoku commented on code in PR #42426:
URL: https://github.com/apache/spark/pull/42426#discussion_r1289988068


##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RetryingBlockTransferor.java:
##########
@@ -149,6 +149,7 @@ public RetryingBlockTransferor(
    * in the event of transient IOExceptions.
    */
   public void start() {
+    currentListener = new RetryingBlockTransferListener();

Review Comment:
   This is needed to spy `RetryingBlockTransferor` as, in the constructor, `this` still bounds to the unspied instance, and hence the inner class instance will also inherit it and [this](https://github.com/apache/spark/blob/a223bc8c34ce4028c95985439d7b671162e56571/common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RetryingBlockTransferor.java#L286) will invoke the real implementation.
   
   <img width="1120" alt="image" src="https://github.com/apache/spark/assets/17327104/232bc4f7-9608-43ae-acf6-5de658b5ed00">
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org