[GitHub] [incubator-pinot] akshayrai commented on a change in pull request #6486: [TE] migrate PQL queries to standard SQL

[GitBox <gi...@apache.org>]

akshayrai commented on a change in pull request #6486:
URL: https://github.com/apache/incubator-pinot/pull/6486#discussion_r564109718



##########
File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datasource/pinot/SqlUtils.java
##########
@@ -393,7 +398,7 @@ static String quote(String value) {
     String quoteChar = "";
     if (!StringUtils.isNumeric(value)) {
       quoteChar = "\"";
-      if (value.contains(quoteChar)) {
+      if (value.contains(quoteChar) || StringUtils.isEmpty(value)) {

Review comment:
       StringUtils.isEmpty also checks for null. Better to run this check first `StringUtils.isEmpty(value) || value.contains(quoteChar)`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org