You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mrunit.apache.org by "Jim Donofrio (Created) (JIRA)" <ji...@apache.org> on 2012/04/03 15:06:27 UTC
[jira] [Created] (MRUNIT-95) use Serialization framework to change
all add input methods to serialize, deserialize to do defensive copying
into input lists
use Serialization framework to change all add input methods to serialize, deserialize to do defensive copying into input lists
------------------------------------------------------------------------------------------------------------------------------
Key: MRUNIT-95
URL: https://issues.apache.org/jira/browse/MRUNIT-95
Project: MRUnit
Issue Type: Improvement
Affects Versions: 0.9.0
Reporter: Jim Donofrio
Priority: Minor
Use Serialization framework to change all add input methods to serialize, deserialize to do defensive copying into input lists. This will prevent users from modifying input objects by accident and then having a test fail. The one problem is ideally this defensive copying would be done when the user calls addInput. The problem is dealing with custom serializations that require a setting in the conf. Users would have to make sure to set the property in the conf before adding any input, this may break some existing test programs. I guess we can just throw a meaningful exception in the add method when we cannot serialize, deserialize. Any thoughts?
Also deprecate and eventually remove getInputValues method in ReduceDriverBase to prevent access to the input list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-95) use Serialization framework to
change all set/add input/output methods to serialize, deserialize to do
defensive copying
Posted by "Jim Donofrio (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255284#comment-13255284 ]
Jim Donofrio commented on MRUNIT-95:
------------------------------------
added copy convenience methods to TestDriver
call copy convenience methods on all set/add input/output methods
committed in 1326898
> use Serialization framework to change all set/add input/output methods to serialize, deserialize to do defensive copying
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: MRUNIT-95
> URL: https://issues.apache.org/jira/browse/MRUNIT-95
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Jim Donofrio
> Assignee: Jim Donofrio
> Priority: Minor
> Labels: serialization
> Fix For: 1.0.0
>
>
> Use Serialization framework to change all set/add input/output methods to serialize, deserialize to do defensive copying. This will prevent users from modifying input/expected output objects by accident. The one problem is dealing with custom serializations that require a setting in the conf. Users would have to make sure to set the property in the conf before adding any input/output, this may break some existing test programs. I guess we can just throw a meaningful exception in the add method when we cannot serialize, deserialize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-95) use Serialization framework to
change all add input methods to serialize, deserialize to do defensive
copying into input lists
Posted by "Brock Noland (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245351#comment-13245351 ]
Brock Noland commented on MRUNIT-95:
------------------------------------
This won't affect MRUNIT-19 correct?
> use Serialization framework to change all add input methods to serialize, deserialize to do defensive copying into input lists
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: MRUNIT-95
> URL: https://issues.apache.org/jira/browse/MRUNIT-95
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Jim Donofrio
> Priority: Minor
> Labels: serialization
>
> Use Serialization framework to change all add input methods to serialize, deserialize to do defensive copying into input lists. This will prevent users from modifying input objects by accident and then having a test fail. The one problem is ideally this defensive copying would be done when the user calls addInput. The problem is dealing with custom serializations that require a setting in the conf. Users would have to make sure to set the property in the conf before adding any input, this may break some existing test programs. I guess we can just throw a meaningful exception in the add method when we cannot serialize, deserialize. Any thoughts?
> Also deprecate and eventually remove getInputValues method in ReduceDriverBase to prevent access to the input list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MRUNIT-95) use Serialization framework to change
all set/add input/output methods to serialize, deserialize to do defensive
copying
Posted by "Jim Donofrio (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Donofrio updated MRUNIT-95:
-------------------------------
Description: Use Serialization framework to change all set/add input/output methods to serialize, deserialize to do defensive copying. This will prevent users from modifying input/expected output objects by accident. The one problem is dealing with custom serializations that require a setting in the conf. Users would have to make sure to set the property in the conf before adding any input/output, this may break some existing test programs. I guess we can just throw a meaningful exception in the add method when we cannot serialize, deserialize. (was: Use Serialization framework to change all add input methods to serialize, deserialize to do defensive copying into input lists. This will prevent users from modifying input objects by accident and then having a test fail. The one problem is ideally this defensive copying would be done when the user calls addInput. The problem is dealing with custom serializations that require a setting in the conf. Users would have to make sure to set the property in the conf before adding any input, this may break some existing test programs. I guess we can just throw a meaningful exception in the add method when we cannot serialize, deserialize. Any thoughts?
Also deprecate and eventually remove getInputValues method in ReduceDriverBase to prevent access to the input list.)
Summary: use Serialization framework to change all set/add input/output methods to serialize, deserialize to do defensive copying (was: use Serialization framework to change all add input methods to serialize, deserialize to do defensive copying into input lists)
> use Serialization framework to change all set/add input/output methods to serialize, deserialize to do defensive copying
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: MRUNIT-95
> URL: https://issues.apache.org/jira/browse/MRUNIT-95
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Jim Donofrio
> Assignee: Jim Donofrio
> Priority: Minor
> Labels: serialization
> Fix For: 1.0.0
>
>
> Use Serialization framework to change all set/add input/output methods to serialize, deserialize to do defensive copying. This will prevent users from modifying input/expected output objects by accident. The one problem is dealing with custom serializations that require a setting in the conf. Users would have to make sure to set the property in the conf before adding any input/output, this may break some existing test programs. I guess we can just throw a meaningful exception in the add method when we cannot serialize, deserialize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MRUNIT-95) use Serialization framework to change
all set/add input/output methods to serialize, deserialize to do defensive
copying
Posted by "Jim Donofrio (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Donofrio updated MRUNIT-95:
-------------------------------
Fix Version/s: 1.0.0
> use Serialization framework to change all set/add input/output methods to serialize, deserialize to do defensive copying
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: MRUNIT-95
> URL: https://issues.apache.org/jira/browse/MRUNIT-95
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Jim Donofrio
> Assignee: Jim Donofrio
> Priority: Minor
> Labels: serialization
> Fix For: 1.0.0
>
>
> Use Serialization framework to change all set/add input/output methods to serialize, deserialize to do defensive copying. This will prevent users from modifying input/expected output objects by accident. The one problem is dealing with custom serializations that require a setting in the conf. Users would have to make sure to set the property in the conf before adding any input/output, this may break some existing test programs. I guess we can just throw a meaningful exception in the add method when we cannot serialize, deserialize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MRUNIT-95) use Serialization framework to change
all set/add input/output methods to serialize, deserialize to do defensive
copying
Posted by "Jim Donofrio (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Donofrio resolved MRUNIT-95.
--------------------------------
Resolution: Fixed
added tests
committed in 1327353
> use Serialization framework to change all set/add input/output methods to serialize, deserialize to do defensive copying
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: MRUNIT-95
> URL: https://issues.apache.org/jira/browse/MRUNIT-95
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Jim Donofrio
> Assignee: Jim Donofrio
> Priority: Minor
> Labels: serialization
> Fix For: 1.0.0
>
>
> Use Serialization framework to change all set/add input/output methods to serialize, deserialize to do defensive copying. This will prevent users from modifying input/expected output objects by accident. The one problem is dealing with custom serializations that require a setting in the conf. Users would have to make sure to set the property in the conf before adding any input/output, this may break some existing test programs. I guess we can just throw a meaningful exception in the add method when we cannot serialize, deserialize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MRUNIT-95) use Serialization framework to change
all add input methods to serialize, deserialize to do defensive copying
into input lists
Posted by "Jim Donofrio (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-95?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Donofrio reassigned MRUNIT-95:
----------------------------------
Assignee: Jim Donofrio
> use Serialization framework to change all add input methods to serialize, deserialize to do defensive copying into input lists
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: MRUNIT-95
> URL: https://issues.apache.org/jira/browse/MRUNIT-95
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Jim Donofrio
> Assignee: Jim Donofrio
> Priority: Minor
> Labels: serialization
>
> Use Serialization framework to change all add input methods to serialize, deserialize to do defensive copying into input lists. This will prevent users from modifying input objects by accident and then having a test fail. The one problem is ideally this defensive copying would be done when the user calls addInput. The problem is dealing with custom serializations that require a setting in the conf. Users would have to make sure to set the property in the conf before adding any input, this may break some existing test programs. I guess we can just throw a meaningful exception in the add method when we cannot serialize, deserialize. Any thoughts?
> Also deprecate and eventually remove getInputValues method in ReduceDriverBase to prevent access to the input list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-95) use Serialization framework to
change all set/add input/output methods to serialize, deserialize to do
defensive copying
Posted by "Jim Donofrio (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255240#comment-13255240 ]
Jim Donofrio commented on MRUNIT-95:
------------------------------------
changed Serialization class to have a constructor that provides the conf
committed in 1326859
> use Serialization framework to change all set/add input/output methods to serialize, deserialize to do defensive copying
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: MRUNIT-95
> URL: https://issues.apache.org/jira/browse/MRUNIT-95
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Jim Donofrio
> Assignee: Jim Donofrio
> Priority: Minor
> Labels: serialization
> Fix For: 1.0.0
>
>
> Use Serialization framework to change all set/add input/output methods to serialize, deserialize to do defensive copying. This will prevent users from modifying input/expected output objects by accident. The one problem is dealing with custom serializations that require a setting in the conf. Users would have to make sure to set the property in the conf before adding any input/output, this may break some existing test programs. I guess we can just throw a meaningful exception in the add method when we cannot serialize, deserialize.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MRUNIT-95) use Serialization framework to
change all add input methods to serialize, deserialize to do defensive
copying into input lists
Posted by "Jim Donofrio (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MRUNIT-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245868#comment-13245868 ]
Jim Donofrio commented on MRUNIT-95:
------------------------------------
Yes this wont affect MRUNIT-19. This will only ensure that the list of input has unique values as we do currently on the output with the Serialization.copy method
> use Serialization framework to change all add input methods to serialize, deserialize to do defensive copying into input lists
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: MRUNIT-95
> URL: https://issues.apache.org/jira/browse/MRUNIT-95
> Project: MRUnit
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Jim Donofrio
> Priority: Minor
> Labels: serialization
>
> Use Serialization framework to change all add input methods to serialize, deserialize to do defensive copying into input lists. This will prevent users from modifying input objects by accident and then having a test fail. The one problem is ideally this defensive copying would be done when the user calls addInput. The problem is dealing with custom serializations that require a setting in the conf. Users would have to make sure to set the property in the conf before adding any input, this may break some existing test programs. I guess we can just throw a meaningful exception in the add method when we cannot serialize, deserialize. Any thoughts?
> Also deprecate and eventually remove getInputValues method in ReduceDriverBase to prevent access to the input list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira