You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by sr...@apache.org on 2018/11/01 11:39:58 UTC

[incubator-plc4x] branch master updated: [plc4j-ads] re-enable test

This is an automated email from the ASF dual-hosted git repository.

sruehl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-plc4x.git


The following commit(s) were added to refs/heads/master by this push:
     new d541b3b  [plc4j-ads] re-enable test
d541b3b is described below

commit d541b3b8e7f89cf4fbbf7ef83b2eef2c0b0c97ba
Author: Sebastian Rühl <sr...@apache.org>
AuthorDate: Thu Nov 1 12:39:41 2018 +0100

    [plc4j-ads] re-enable test
---
 .../apache/plc4x/java/ads/connection/AdsAbstractPlcConnectionTest.java | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/plc4j/protocols/ads/src/test/java/org/apache/plc4x/java/ads/connection/AdsAbstractPlcConnectionTest.java b/plc4j/protocols/ads/src/test/java/org/apache/plc4x/java/ads/connection/AdsAbstractPlcConnectionTest.java
index a1517b3..9fe9648 100644
--- a/plc4j/protocols/ads/src/test/java/org/apache/plc4x/java/ads/connection/AdsAbstractPlcConnectionTest.java
+++ b/plc4j/protocols/ads/src/test/java/org/apache/plc4x/java/ads/connection/AdsAbstractPlcConnectionTest.java
@@ -176,7 +176,6 @@ public class AdsAbstractPlcConnectionTest {
         SUT.mapFields(mock(PlcFieldRequest.class));
     }
 
-    @Ignore("Currently broken // TODO // FIXME")
     @Test
     public void mapField() {
         // positive
@@ -211,7 +210,7 @@ public class AdsAbstractPlcConnectionTest {
             });
 
             assertThrows(PlcRuntimeException.class, () -> SUT.mapFields(SymbolicAdsField.of("Main.byByte[0]")));
-            verify(channel, times(1)).writeAndFlush(any(PlcRequestContainer.class));
+            verify(channel, times(0)).writeAndFlush(any(PlcRequestContainer.class));
             SUT.clearMapping();
             reset(channel);
         }