You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Christofer Dutz <ch...@c-ware.de> on 2016/07/07 14:46:20 UTC

[Falcon] Move the Ant task code into a separate module?

Hi,


while working on the distribution, I was confused why there was an "ant.jar" in my "lib/ext" directory. I noticed pretty soon that the compiler seems to contain the flex ant tasks. I think they don't belong in there and I'd like to move them into a separate module.


Are you ok with that? While the Maven build will probably be easy, the Ant build would have to be adjusted.


Chris

AW: [Falcon] Move the Ant task code into a separate module?

Posted by Christofer Dutz <ch...@c-ware.de>.
I pushed my changes to a separate branch "feature/flexjs-ant-tasks". So please have a look. If there are no objections I would merge those changes back to develop. So if you could fix the Ant build in that branch, we wouldn't break anything.


Chris

________________________________
Von: Christofer Dutz <ch...@c-ware.de>
Gesendet: Freitag, 8. Juli 2016 22:46:30
An: dev@flex.apache.org
Betreff: AW: [Falcon] Move the Ant task code into a separate module?

Ok,


so I just checked this, and the refactoring is very easy as the Ant-Tasks doesn't seem to have any dependencies to the compiler and the compiler doesn't seem to have dependencies on the Ant-Tasks. All that would have to be adjusted, would be the Ant scripts that build the falcon-flexTasks.jar from sources in another directory. As this build has absolutely no magic in it, I doubt it will take long.


Chris

________________________________
Von: Christofer Dutz <ch...@c-ware.de>
Gesendet: Donnerstag, 7. Juli 2016 16:55:56
An: dev@flex.apache.org
Betreff: AW: [Falcon] Move the Ant task code into a separate module?

I would like to as this is part of the cleanup process and the current version doesn't produce a antTargets jar.


But I'm not demanding this to be finished before a release.


Chris

________________________________
Von: Alex Harui <ah...@adobe.com>
Gesendet: Donnerstag, 7. Juli 2016 16:51:17
An: dev@flex.apache.org
Betreff: Re: [Falcon] Move the Ant task code into a separate module?

Makes sense.  Do we want to do this before we release 0.7.0?

On 7/7/16, 7:46 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:

>Hi,
>
>
>while working on the distribution, I was confused why there was an
>"ant.jar" in my "lib/ext" directory. I noticed pretty soon that the
>compiler seems to contain the flex ant tasks. I think they don't belong
>in there and I'd like to move them into a separate module.
>
>
>Are you ok with that? While the Maven build will probably be easy, the
>Ant build would have to be adjusted.
>
>
>Chris


AW: [Falcon] Move the Ant task code into a separate module?

Posted by Christofer Dutz <ch...@c-ware.de>.
Ok,


so I just checked this, and the refactoring is very easy as the Ant-Tasks doesn't seem to have any dependencies to the compiler and the compiler doesn't seem to have dependencies on the Ant-Tasks. All that would have to be adjusted, would be the Ant scripts that build the falcon-flexTasks.jar from sources in another directory. As this build has absolutely no magic in it, I doubt it will take long.


Chris

________________________________
Von: Christofer Dutz <ch...@c-ware.de>
Gesendet: Donnerstag, 7. Juli 2016 16:55:56
An: dev@flex.apache.org
Betreff: AW: [Falcon] Move the Ant task code into a separate module?

I would like to as this is part of the cleanup process and the current version doesn't produce a antTargets jar.


But I'm not demanding this to be finished before a release.


Chris

________________________________
Von: Alex Harui <ah...@adobe.com>
Gesendet: Donnerstag, 7. Juli 2016 16:51:17
An: dev@flex.apache.org
Betreff: Re: [Falcon] Move the Ant task code into a separate module?

Makes sense.  Do we want to do this before we release 0.7.0?

On 7/7/16, 7:46 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:

>Hi,
>
>
>while working on the distribution, I was confused why there was an
>"ant.jar" in my "lib/ext" directory. I noticed pretty soon that the
>compiler seems to contain the flex ant tasks. I think they don't belong
>in there and I'd like to move them into a separate module.
>
>
>Are you ok with that? While the Maven build will probably be easy, the
>Ant build would have to be adjusted.
>
>
>Chris


AW: [Falcon] Move the Ant task code into a separate module?

Posted by Christofer Dutz <ch...@c-ware.de>.
I would like to as this is part of the cleanup process and the current version doesn't produce a antTargets jar.


But I'm not demanding this to be finished before a release.


Chris

________________________________
Von: Alex Harui <ah...@adobe.com>
Gesendet: Donnerstag, 7. Juli 2016 16:51:17
An: dev@flex.apache.org
Betreff: Re: [Falcon] Move the Ant task code into a separate module?

Makes sense.  Do we want to do this before we release 0.7.0?

On 7/7/16, 7:46 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:

>Hi,
>
>
>while working on the distribution, I was confused why there was an
>"ant.jar" in my "lib/ext" directory. I noticed pretty soon that the
>compiler seems to contain the flex ant tasks. I think they don't belong
>in there and I'd like to move them into a separate module.
>
>
>Are you ok with that? While the Maven build will probably be easy, the
>Ant build would have to be adjusted.
>
>
>Chris


Re: [Falcon] Move the Ant task code into a separate module?

Posted by Alex Harui <ah...@adobe.com>.
Makes sense.  Do we want to do this before we release 0.7.0?

On 7/7/16, 7:46 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:

>Hi,
>
>
>while working on the distribution, I was confused why there was an
>"ant.jar" in my "lib/ext" directory. I noticed pretty soon that the
>compiler seems to contain the flex ant tasks. I think they don't belong
>in there and I'd like to move them into a separate module.
>
>
>Are you ok with that? While the Maven build will probably be easy, the
>Ant build would have to be adjusted.
>
>
>Chris