You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2020/09/23 16:41:04 UTC

[Impala-ASF-CR] [not for merge] Testing whether changing impala-ir.cc leads to compilation issues

Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16497


Change subject: [not for merge] Testing whether changing impala-ir.cc leads to compilation issues
......................................................................

[not for merge] Testing whether changing impala-ir.cc leads to compilation issues

Change-Id: Iecd13502dd5ff90b63c8271cc62df254bebe06b0
---
M be/src/codegen/impala-ir.cc
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/16497/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iecd13502dd5ff90b63c8271cc62df254bebe06b0
Gerrit-Change-Number: 16497
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>

[Impala-ASF-CR] [not for merge] Investigating clang to compilation issue

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16497

to look at the new patch set (#4).

Change subject: [not for merge] Investigating clang to compilation issue
......................................................................

[not for merge] Investigating clang to compilation issue

Change-Id: Iecd13502dd5ff90b63c8271cc62df254bebe06b0
---
M be/CMakeLists.txt
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/16497/4
-- 
To view, visit http://gerrit.cloudera.org:8080/16497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iecd13502dd5ff90b63c8271cc62df254bebe06b0
Gerrit-Change-Number: 16497
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] [not for merge] Investigating clang to compilation issue

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has abandoned this change. ( http://gerrit.cloudera.org:8080/16497 )

Change subject: [not for merge] Investigating clang to compilation issue
......................................................................


Abandoned
-- 
To view, visit http://gerrit.cloudera.org:8080/16497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Iecd13502dd5ff90b63c8271cc62df254bebe06b0
Gerrit-Change-Number: 16497
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] [not for merge] Investigating clang to compilation issue

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16497

to look at the new patch set (#5).

Change subject: [not for merge] Investigating clang to compilation issue
......................................................................

[not for merge] Investigating clang to compilation issue

Change-Id: Iecd13502dd5ff90b63c8271cc62df254bebe06b0
---
M be/CMakeLists.txt
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/16497/5
-- 
To view, visit http://gerrit.cloudera.org:8080/16497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iecd13502dd5ff90b63c8271cc62df254bebe06b0
Gerrit-Change-Number: 16497
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] [not for merge] Testing whether changing impala-ir.cc leads to compilation issues

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16497 )

Change subject: [not for merge] Testing whether changing impala-ir.cc leads to compilation issues
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7249/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecd13502dd5ff90b63c8271cc62df254bebe06b0
Gerrit-Change-Number: 16497
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Sep 2020 17:02:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [not for merge] Investigating clang to compilation issue

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16497 )

Change subject: [not for merge] Investigating clang to compilation issue
......................................................................


Patch Set 4:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/7253/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/16497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecd13502dd5ff90b63c8271cc62df254bebe06b0
Gerrit-Change-Number: 16497
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Sep 2020 18:08:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [not for merge] Testing whether changing impala-ir.cc leads to compilation issues

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16497 )

Change subject: [not for merge] Testing whether changing impala-ir.cc leads to compilation issues
......................................................................


Patch Set 2:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/7250/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/16497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecd13502dd5ff90b63c8271cc62df254bebe06b0
Gerrit-Change-Number: 16497
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Sep 2020 17:27:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [not for merge] Investigating clang to compilation issue

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16497 )

Change subject: [not for merge] Investigating clang to compilation issue
......................................................................


Patch Set 5:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/7254/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/16497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecd13502dd5ff90b63c8271cc62df254bebe06b0
Gerrit-Change-Number: 16497
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Sep 2020 18:14:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [not for merge] Testing whether changing impala-ir.cc leads to compilation issues

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16497

to look at the new patch set (#3).

Change subject: [not for merge] Testing whether changing impala-ir.cc leads to compilation issues
......................................................................

[not for merge] Testing whether changing impala-ir.cc leads to compilation issues

Change-Id: Iecd13502dd5ff90b63c8271cc62df254bebe06b0
---
M be/CMakeLists.txt
M be/src/codegen/impala-ir.cc
2 files changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/16497/3
-- 
To view, visit http://gerrit.cloudera.org:8080/16497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iecd13502dd5ff90b63c8271cc62df254bebe06b0
Gerrit-Change-Number: 16497
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] [not for merge] Testing whether changing impala-ir.cc leads to compilation issues

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16497 )

Change subject: [not for merge] Testing whether changing impala-ir.cc leads to compilation issues
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7251/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecd13502dd5ff90b63c8271cc62df254bebe06b0
Gerrit-Change-Number: 16497
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 23 Sep 2020 17:53:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] [not for merge] Testing whether changing impala-ir.cc leads to compilation issues

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16497

to look at the new patch set (#2).

Change subject: [not for merge] Testing whether changing impala-ir.cc leads to compilation issues
......................................................................

[not for merge] Testing whether changing impala-ir.cc leads to compilation issues

Change-Id: Iecd13502dd5ff90b63c8271cc62df254bebe06b0
---
M be/CMakeLists.txt
M be/src/codegen/impala-ir.cc
2 files changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/16497/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iecd13502dd5ff90b63c8271cc62df254bebe06b0
Gerrit-Change-Number: 16497
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>