You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/21 01:28:11 UTC

[GitHub] [pulsar] zymap commented on issue #9962: [Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion

zymap commented on issue #9962:
URL: https://github.com/apache/pulsar/issues/9962#issuecomment-823708539


   There has a delete method for the offload data but looks like we didn't trigger it when deleting a topic. 
   
   When we deleting a topic, it will delete from the bookkeeper directly(https://github.com/apache/pulsar/blob/ef06691531002c5d7cdbbdafc5494914ee8e0765/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java#L2569), and I found the offload data only deleted when a ledger closed or rollover. 
   I think we can trigger this method (https://github.com/apache/pulsar/blob/ef06691531002c5d7cdbbdafc5494914ee8e0765/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java#L2534) when we deleting a topic that would be deleting the offload data if the ledger had been offloaded.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org