[GitHub] [iceberg] singhpk234 commented on a diff in pull request #7387: Hive: Add engine name/version to EnvironmentContext

["singhpk234 (via GitHub)" <gi...@apache.org>]

singhpk234 commented on code in PR #7387:
URL: https://github.com/apache/iceberg/pull/7387#discussion_r1172844880


##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -108,6 +110,9 @@ public void initialize(String inputName, Map<String, String> properties) {
             : CatalogUtil.loadFileIO(fileIOImpl, properties, conf);
 
     this.clients = new CachedClientPool(conf, properties);
+
+    EnvironmentContext.put(EnvironmentContext.ENGINE_NAME, "hive");
+    EnvironmentContext.put(EnvironmentContext.ENGINE_VERSION, HiveVersionInfo.getVersion());

Review Comment:
   [doubt] can't HiveCatalog be used with spark engine ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org