You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "Stefan Guggisberg (Created) (JIRA)" <ji...@apache.org> on 2012/04/10 09:52:18 UTC

[jira] [Created] (OAK-53) exclude longer running tests in the default maven profile

exclude longer running tests in the default maven profile
---------------------------------------------------------

                 Key: OAK-53
                 URL: https://issues.apache.org/jira/browse/OAK-53
             Project: Jackrabbit Oak
          Issue Type: Test
            Reporter: Stefan Guggisberg


the current maven build using the default profile takes ~3min on my machine which is IMO way too long.

'mvn clean install' should IMO allow quick turn around cycles during development and finish within a couple of seconds.

requiring the developers to use a custom maven profile dring development (as suggested in OAK-52) is IMO not acceptable. custom profiles are hard to remember when working on different projects. 
 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OAK-53) exclude longer running tests in the default maven profile

Posted by "Stefan Guggisberg (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OAK-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250532#comment-13250532 ] 

Stefan Guggisberg commented on OAK-53:
--------------------------------------

if 'mvn clean install' takes too long i guess i'll be using 'mvn clean install -DskipTests' instead. 
                
> exclude longer running tests in the default maven profile
> ---------------------------------------------------------
>
>                 Key: OAK-53
>                 URL: https://issues.apache.org/jira/browse/OAK-53
>             Project: Jackrabbit Oak
>          Issue Type: Test
>            Reporter: Stefan Guggisberg
>
> the current maven build using the default profile takes ~3min on my machine which is IMO way too long.
> 'mvn clean install' should IMO allow quick turn around cycles during development and finish within a couple of seconds.
> requiring the developers to use a custom maven profile dring development (as suggested in OAK-52) is IMO not acceptable. custom profiles are hard to remember when working on different projects. 
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OAK-53) exclude longer running tests in the default maven profile

Posted by "angela (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OAK-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250496#comment-13250496 ] 

angela commented on OAK-53:
---------------------------

i would like to second that... time consuming tests should be moved to automated test on the build server.
                
> exclude longer running tests in the default maven profile
> ---------------------------------------------------------
>
>                 Key: OAK-53
>                 URL: https://issues.apache.org/jira/browse/OAK-53
>             Project: Jackrabbit Oak
>          Issue Type: Test
>            Reporter: Stefan Guggisberg
>
> the current maven build using the default profile takes ~3min on my machine which is IMO way too long.
> 'mvn clean install' should IMO allow quick turn around cycles during development and finish within a couple of seconds.
> requiring the developers to use a custom maven profile dring development (as suggested in OAK-52) is IMO not acceptable. custom profiles are hard to remember when working on different projects. 
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OAK-53) exclude longer running tests in the default maven profile

Posted by "Michael Dürig (Commented JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OAK-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250523#comment-13250523 ] 

Michael Dürig commented on OAK-53:
----------------------------------

We should leave the current setup until the Microkernel test suite is up to it. These tests actually found quite a number of bugs in the Microkernel which should have been caught by a dedicated test suite. Having to remember to type -Psmoke-test for skipping those is a comparably small inconvenience. 
                
> exclude longer running tests in the default maven profile
> ---------------------------------------------------------
>
>                 Key: OAK-53
>                 URL: https://issues.apache.org/jira/browse/OAK-53
>             Project: Jackrabbit Oak
>          Issue Type: Test
>            Reporter: Stefan Guggisberg
>
> the current maven build using the default profile takes ~3min on my machine which is IMO way too long.
> 'mvn clean install' should IMO allow quick turn around cycles during development and finish within a couple of seconds.
> requiring the developers to use a custom maven profile dring development (as suggested in OAK-52) is IMO not acceptable. custom profiles are hard to remember when working on different projects. 
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Resolved] (OAK-53) exclude longer running tests in the default maven profile

Posted by "Jukka Zitting (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/OAK-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jukka Zitting resolved OAK-53.
------------------------------

       Resolution: Fixed
    Fix Version/s: 0.2
         Assignee: Jukka Zitting

I took the liberty of replacing the smoke-test profile with an integrationTesting profile that works in the opposite way. Instead of disabling long-running tests, the integrationTesting profile explicitly enables the tests that are now by default disabled.

Ideally running a unit test in the default "mvn clean install" build shouldn't take much longer than compiling the relevant classes. Any longer-running tests should only be executed when the integrationTesting profile is enabled (which should be the case in automatic CI builds).

To mark a test as time-consuming or otherwise a part of the integration test suite, name it SomethingIT (as in "integration test") instead of SomethingTest. See the Maven Failsafe plugin documentation for more details.
                
> exclude longer running tests in the default maven profile
> ---------------------------------------------------------
>
>                 Key: OAK-53
>                 URL: https://issues.apache.org/jira/browse/OAK-53
>             Project: Jackrabbit Oak
>          Issue Type: Test
>            Reporter: Stefan Guggisberg
>            Assignee: Jukka Zitting
>             Fix For: 0.2
>
>
> the current maven build using the default profile takes ~3min on my machine which is IMO way too long.
> 'mvn clean install' should IMO allow quick turn around cycles during development and finish within a couple of seconds.
> requiring the developers to use a custom maven profile dring development (as suggested in OAK-52) is IMO not acceptable. custom profiles are hard to remember when working on different projects. 
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (OAK-53) exclude longer running tests in the default maven profile

Posted by "Dominique Pfister (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/OAK-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250629#comment-13250629 ] 

Dominique Pfister commented on OAK-53:
--------------------------------------

+1

IMO, long running tests are a PITA, and drives me to make local changes to ignore them or even skip the whole test suite. I definitely prefer to exclude such tests in the default profile.

                
> exclude longer running tests in the default maven profile
> ---------------------------------------------------------
>
>                 Key: OAK-53
>                 URL: https://issues.apache.org/jira/browse/OAK-53
>             Project: Jackrabbit Oak
>          Issue Type: Test
>            Reporter: Stefan Guggisberg
>
> the current maven build using the default profile takes ~3min on my machine which is IMO way too long.
> 'mvn clean install' should IMO allow quick turn around cycles during development and finish within a couple of seconds.
> requiring the developers to use a custom maven profile dring development (as suggested in OAK-52) is IMO not acceptable. custom profiles are hard to remember when working on different projects. 
>  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira