You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "kfaraz (via GitHub)" <gi...@apache.org> on 2023/05/25 04:02:37 UTC

[GitHub] [druid] kfaraz commented on a diff in pull request #14337: Fix regression in batch segment allocation

kfaraz commented on code in PR #14337:
URL: https://github.com/apache/druid/pull/14337#discussion_r1204969261


##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentAllocationQueue.java:
##########
@@ -364,7 +364,11 @@ private boolean processBatch(AllocateRequestBatch requestBatch)
     final Set<DataSegment> updatedUsedSegments = retrieveUsedSegments(requestKey);
 
     if (updatedUsedSegments.equals(usedSegments)) {
-      requestBatch.failPendingRequests("Allocation failed probably due to conflicting segments.");
+      log.info(

Review Comment:
   Updated to include the batch key, which has datasource, groupId and preferredAllocInterval.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org