You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hannah Nguyen (Code Review)" <ge...@cloudera.org> on 2019/08/16 23:28:39 UTC
[kudu-CR] Minor update to kudu-tool-test for macOS.
Hannah Nguyen has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14085
Change subject: Minor update to kudu-tool-test for macOS.
......................................................................
Minor update to kudu-tool-test for macOS.
Test ClusterNameResolverFileCorrupt should fail with a
slightly different error message when in macOS instead
of Linux.
Change-Id: I6ccf7103ae59fe93087be8654cd663a043d2be0e
---
M src/kudu/tools/kudu-tool-test.cc
1 file changed, 15 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/14085/1
--
To view, visit http://gerrit.cloudera.org:8080/14085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ccf7103ae59fe93087be8654cd663a043d2be0e
Gerrit-Change-Number: 14085
Gerrit-PatchSet: 1
Gerrit-Owner: Hannah Nguyen <ha...@cloudera.com>
[kudu-CR] Minor update to kudu-tool-test for macOS.
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14085 )
Change subject: Minor update to kudu-tool-test for macOS.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14085/2/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/14085/2/src/kudu/tools/kudu-tool-test.cc@4918
PS2, Line 4918: Substitute("Network error: Could not connect to the cluster: unable to resolve "
: "address for bad: nodename nor servname provided, or not known")));
I thought the issue was with new versions of macOS only. If so, wouldn't this fail on older versions of macOS?
--
To view, visit http://gerrit.cloudera.org:8080/14085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ccf7103ae59fe93087be8654cd663a043d2be0e
Gerrit-Change-Number: 14085
Gerrit-PatchSet: 2
Gerrit-Owner: Hannah Nguyen <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 17 Aug 2019 02:46:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] Minor update to kudu-tool-test for macOS.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14085 )
Change subject: Minor update to kudu-tool-test for macOS.
......................................................................
Minor update to kudu-tool-test for macOS.
Test ClusterNameResolverFileCorrupt should fail with a
slightly different error message when in macOS instead
of Linux.
Change-Id: I6ccf7103ae59fe93087be8654cd663a043d2be0e
Reviewed-on: http://gerrit.cloudera.org:8080/14085
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/tools/kudu-tool-test.cc
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ccf7103ae59fe93087be8654cd663a043d2be0e
Gerrit-Change-Number: 14085
Gerrit-PatchSet: 3
Gerrit-Owner: Hannah Nguyen <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] Minor update to kudu-tool-test for macOS.
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14085 )
Change subject: Minor update to kudu-tool-test for macOS.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ccf7103ae59fe93087be8654cd663a043d2be0e
Gerrit-Change-Number: 14085
Gerrit-PatchSet: 2
Gerrit-Owner: Hannah Nguyen <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 17 Aug 2019 00:14:07 +0000
Gerrit-HasComments: No
[kudu-CR] Minor update to kudu-tool-test for macOS.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14085 )
Change subject: Minor update to kudu-tool-test for macOS.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14085/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/14085/1/src/kudu/tools/kudu-tool-test.cc@4926
PS1, Line 4926: Network error: Could not connect to the cluster: unable to resolve "
: "address for bad:
maybe, just match the error message with shorter string
"Network error: Could not connect to the cluster: unable to resolve address for bad: "
or interpret the error message parameter as a regex in CheckCorruptClusterInfoConfigFile(), adding the macOS-specific string a part of the pattern?
"Network error: Could not connect to the cluster: unable to resolve address for bad: (Name or service not known|nodename nor servname provided, or not known)"
--
To view, visit http://gerrit.cloudera.org:8080/14085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ccf7103ae59fe93087be8654cd663a043d2be0e
Gerrit-Change-Number: 14085
Gerrit-PatchSet: 1
Gerrit-Owner: Hannah Nguyen <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 16 Aug 2019 23:44:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] Minor update to kudu-tool-test for macOS.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14085 )
Change subject: Minor update to kudu-tool-test for macOS.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14085/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/14085/1/src/kudu/tools/kudu-tool-test.cc@4922
PS1, Line 4922: // Linux
: Substitute("Network error: Could not connect to the cluster: unable to resolve "
: "address for bad: Name or service not known"),
: // macOS
: Substitute("Network error: Could not connect to the cluster: unable to resolve "
: "address for bad: nodename nor servname provided, or not known")));
> Rather than bake the possibility of up to two errors into the code, use the
+1
--
To view, visit http://gerrit.cloudera.org:8080/14085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ccf7103ae59fe93087be8654cd663a043d2be0e
Gerrit-Change-Number: 14085
Gerrit-PatchSet: 1
Gerrit-Owner: Hannah Nguyen <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 16 Aug 2019 23:48:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] Minor update to kudu-tool-test for macOS.
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14085 )
Change subject: Minor update to kudu-tool-test for macOS.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14085/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/14085/1/src/kudu/tools/kudu-tool-test.cc@4922
PS1, Line 4922: // Linux
: Substitute("Network error: Could not connect to the cluster: unable to resolve "
: "address for bad: Name or service not known"),
: // macOS
: Substitute("Network error: Could not connect to the cluster: unable to resolve "
: "address for bad: nodename nor servname provided, or not known")));
Rather than bake the possibility of up to two errors into the code, use the preprocessor:
// Invalid 'master_addresses' value.
NO_FATALS(CheckCorruptClusterInfoConfigFile(
Substitute(R"*(clusters_info:)*""\n"
R"*( $0:)*""\n"
R"*( master_addresses: bad,masters,addresses)*", kClusterName),
#ifdef __APPLE__
Substitute("Network error: Could not connect to the cluster: unable to resolve "
"address for bad: nodename nor servname provided, or not known")));
#else
Substitute("Network error: Could not connect to the cluster: unable to resolve "
"address for bad: Name or service not known")));
#endif
--
To view, visit http://gerrit.cloudera.org:8080/14085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ccf7103ae59fe93087be8654cd663a043d2be0e
Gerrit-Change-Number: 14085
Gerrit-PatchSet: 1
Gerrit-Owner: Hannah Nguyen <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 16 Aug 2019 23:37:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] Minor update to kudu-tool-test for macOS.
Posted by "Hannah Nguyen (Code Review)" <ge...@cloudera.org>.
Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14085 )
Change subject: Minor update to kudu-tool-test for macOS.
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14085/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/14085/1/src/kudu/tools/kudu-tool-test.cc@627
PS1, Line 627: }
> warning: the 'empty' method should be used to check for emptiness instead o
Done
http://gerrit.cloudera.org:8080/#/c/14085/1/src/kudu/tools/kudu-tool-test.cc@4922
PS1, Line 4922: "address for bad: Name or service not known")));
: #endif
: }
:
: TEST_F(ToolTest, ClusterNameResolverNormal) {
: ExternalMiniClusterOptions opts;
> Rather than bake the possibility of up to two errors into the code, use the
Done
http://gerrit.cloudera.org:8080/#/c/14085/1/src/kudu/tools/kudu-tool-test.cc@4926
PS1, Line 4926: meResolverNormal) {
: ExternalMiniClusterOptions opts;
> maybe, just match the error message with shorter string
Done
--
To view, visit http://gerrit.cloudera.org:8080/14085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ccf7103ae59fe93087be8654cd663a043d2be0e
Gerrit-Change-Number: 14085
Gerrit-PatchSet: 2
Gerrit-Owner: Hannah Nguyen <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 16 Aug 2019 23:55:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] Minor update to kudu-tool-test for macOS.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14085 )
Change subject: Minor update to kudu-tool-test for macOS.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ccf7103ae59fe93087be8654cd663a043d2be0e
Gerrit-Change-Number: 14085
Gerrit-PatchSet: 2
Gerrit-Owner: Hannah Nguyen <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 17 Aug 2019 00:25:37 +0000
Gerrit-HasComments: No
[kudu-CR] Minor update to kudu-tool-test for macOS.
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14085 )
Change subject: Minor update to kudu-tool-test for macOS.
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14085/2/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/14085/2/src/kudu/tools/kudu-tool-test.cc@4918
PS2, Line 4918: Substitute("Network error: Could not connect to the cluster: unable to resolve "
: "address for bad: nodename nor servname provided, or not known")));
> I thought the issue was with new versions of macOS only. If so, wouldn't th
This works for me on 10.11.6
--
To view, visit http://gerrit.cloudera.org:8080/14085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ccf7103ae59fe93087be8654cd663a043d2be0e
Gerrit-Change-Number: 14085
Gerrit-PatchSet: 2
Gerrit-Owner: Hannah Nguyen <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sat, 17 Aug 2019 03:26:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] Minor update to kudu-tool-test for macOS.
Posted by "Hannah Nguyen (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14085
to look at the new patch set (#2).
Change subject: Minor update to kudu-tool-test for macOS.
......................................................................
Minor update to kudu-tool-test for macOS.
Test ClusterNameResolverFileCorrupt should fail with a
slightly different error message when in macOS instead
of Linux.
Change-Id: I6ccf7103ae59fe93087be8654cd663a043d2be0e
---
M src/kudu/tools/kudu-tool-test.cc
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/14085/2
--
To view, visit http://gerrit.cloudera.org:8080/14085
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6ccf7103ae59fe93087be8654cd663a043d2be0e
Gerrit-Change-Number: 14085
Gerrit-PatchSet: 2
Gerrit-Owner: Hannah Nguyen <ha...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)