[jira] [Commented] (ROCKETMQ-16) Improve the codes of setting topic.json's and subscriptionGroup.json's path

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ROCKETMQ-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15778081#comment-15778081 ] 

ASF GitHub Bot commented on ROCKETMQ-16:
----------------------------------------

GitHub user Zhang-Ke opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/15

    [ROCKETMQ-16] Improve the codes of setting topic.json's and subscriptionGroup.json's path

    [ROCKETMQ-16] Improve the codes of setting topic.json's and subscriptionGroup.json's path
    
    JIRRA ISSUE: [https://issues.apache.org/jira/browse/ROCKETMQ-16](url)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Zhang-Ke/incubator-rocketmq ROCKETMQ-16

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15
    
----
commit 7287170a92e52241832a2b5b8930f8f60b9e1fae
Author: zhangke <zh...@qq.com>
Date:   2016-12-26T10:21:06Z

    [ROCKETMQ-16] Improve the codes of setting topic.json's and subscriptionGroup.json's path

----


> Improve the codes of setting topic.json's and subscriptionGroup.json's path
> ---------------------------------------------------------------------------
>
>                 Key: ROCKETMQ-16
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-16
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>    Affects Versions: 4.0.0-incubating
>            Reporter: ZhangKe
>            Assignee: vongosling
>            Priority: Minor
>             Fix For: 4.0.0-incubating
>
>
> Take TopicConfigManager#configFilePath() for example:
> public String configFilePath() {
> //        return BrokerPathConfigHelper.getTopicConfigPath(this.brokerController.getMessageStoreConfig()
> //                .getStorePathRootDir());
>         return BrokerPathConfigHelper.getTopicConfigPath(System.getProperty("user.home") + File.separator + "store");
>     }
>   
>   As far as I know, the designers of RMQ want to separate topic.json and subscriptionGroup.json(I call them static config files) from store files to make spreading easily(copy them to a new broker directly). So putting them to another dir is reasonable, but we can do it more graceful.
>   At the same time, I add a property named staticConfigFileRootDir in MessageStoreConfig to make their's dir configurable. By default, staticConfigFileRootDir equals storePathRootDir.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)