[GitHub] [couchdb] chewbranca commented on pull request #3633: 3631 3.x fix pq shard creation

[GitBox <gi...@apache.org>]

chewbranca commented on pull request #3633:
URL: https://github.com/apache/couchdb/pull/3633#issuecomment-871816720


   Alright, I've reworked the logic and pushed out a temporary proof of concept in fe75790d9. I took a closer look and the only thing that actually needs to use `couch_db:open` (or at least is _currently_ using it), so I duplicated the `mem3_util:get_or_create_db` function into a `get_or_create_db_int` version, where the differences between the two are `couch_db:open` vs `couch_db:open_int`. Turns out the `dreyfus_rpc` logic is kind of a middle ground, where it uses `open_int` to try and open the db in the fast case, but when it fails it goes through `couch_server:create` which performs the same validations that `couch_server:open` does. I don't want to merge this with the duplication, but I think that commit at least more clearly demonstrates the difference instances. Feedback welcome.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org