[jira] [Commented] (THRIFT-2899) Enum values should be prefixed with the Cocoa namespace

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250338#comment-14250338 ] 

ASF GitHub Bot commented on THRIFT-2899:
----------------------------------------

GitHub user jimspeth opened a pull request:

    https://github.com/apache/thrift/pull/328

    THRIFT-2899: Prefix enum values with the Cocoa namespace.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dwnld/thrift THRIFT-2899

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/328.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #328
    
----
commit 8b147cbd9af8f56e76041cb9329660c3d3a21762
Author: Jim Speth <ji...@dwnld.me>
Date:   2014-12-17T14:40:38Z

    Prefix enum values with the Cocoa namespace.

----


> Enum values should be prefixed with the Cocoa namespace
> -------------------------------------------------------
>
>                 Key: THRIFT-2899
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2899
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Cocoa - Compiler
>            Reporter: Jim Speth
>            Priority: Minor
>
> Enum types are prefixed with the Cocoa namespace, but enum values are not.  This means the values could potentially collide.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)