You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/07 08:21:43 UTC

[GitHub] [spark] eejbyfeldt commented on pull request #38525: [SPARK-40950][BUILD][FOLLOWUP] Fix Scala 2.13 Mima check

eejbyfeldt commented on PR #38525:
URL: https://github.com/apache/spark/pull/38525#issuecomment-1305241501

   Thanks for taking care of this.
   
   Is the reason we are ok with this breakage that we consider inner classes of a private class even though mima I guess does not? 
   
   Should this class be marked private to remove the need for excludes in the future?
   
   Should we not use inner classes seems like we are paying some overhead (the outer class pointer) when we do not really need an inner class? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org