You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ldadima (via GitHub)" <gi...@apache.org> on 2023/09/07 03:31:16 UTC

[GitHub] [flink] ldadima commented on a diff in pull request #23355: [FLINK-33034][runtime] Correct ValueState creating for StateBackendTestBase#testGetKeysAndNamespaces

ldadima commented on code in PR #23355:
URL: https://github.com/apache/flink/pull/23355#discussion_r1318044943


##########
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java:
##########
@@ -500,6 +493,7 @@ public void testGetKeysAndNamespaces() throws Exception {
                                     keysByNamespace.computeIfAbsent(entry.f1, k -> new HashSet<>());
                             assertTrue("Duplicate key for namespace", keys.add(entry.f0));
                         });
+                assertThat(keysByNamespace.size(), is(namespaces.length));

Review Comment:
   This test will be different from the others in the test. I think it's gonna look weird



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org