[jira] Commented: (POOL-155) ObjectPool.invalidateObject(object) should throw an Exception if object is null

["Sebb (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/POOL-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800679#action_12800679 ] 

Sebb commented on POOL-155:
---------------------------

Updated Javadoc:

URL: http://svn.apache.org/viewvc?rev=899609&view=rev
Log:
POOL-155 Clarify that invalidateObject should only be called on a failed object, not a failed borrowObject.

Modified:
   commons/proper/pool/trunk/src/java/org/apache/commons/pool/ObjectPool.java

> ObjectPool.invalidateObject(object) should throw an Exception if object is null
> -------------------------------------------------------------------------------
>
>                 Key: POOL-155
>                 URL: https://issues.apache.org/jira/browse/POOL-155
>             Project: Commons Pool
>          Issue Type: Improvement
>            Reporter: Sebb
>
> ObjectPool.invalidateObject(object) should throw an Exception if object is null, otherwise the numActive count can get out of synch.
> It's easy to do this by mistake, see:
> http://markmail.org/thread/ya22ihmghejbfzme
> Also, the documentation for ObjectPool needs to be updated to clarify that invalidateObject should only be called if the object failed, not the borrow.
> [I'll do this shortly]

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.