You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@texera.apache.org by gi...@apache.org on 2026/07/05 00:03:39 UTC
(texera) branch gh-readonly-queue/main/pr-6114-908a61f08ae521c461ca6c1b7095fc4b99140219 created (now 6de8a48a24)
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a change to branch gh-readonly-queue/main/pr-6114-908a61f08ae521c461ca6c1b7095fc4b99140219
in repository https://gitbox.apache.org/repos/asf/texera.git
at 6de8a48a24 chore: pin y-websocket node image, drop stale toolchain fields (#6114)
This branch includes the following new commits:
new 6de8a48a24 chore: pin y-websocket node image, drop stale toolchain fields (#6114)
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(texera) 01/01: chore: pin y-websocket node image, drop stale toolchain fields (#6114)
Posted by gi...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
github-merge-queue[bot] pushed a commit to branch gh-readonly-queue/main/pr-6114-908a61f08ae521c461ca6c1b7095fc4b99140219
in repository https://gitbox.apache.org/repos/asf/texera.git
commit 6de8a48a24ce95899385eaac672e9a14b0453b2d
Author: Yicong Huang <17...@users.noreply.github.com>
AuthorDate: Sat Jul 4 17:03:18 2026 -0700
chore: pin y-websocket node image, drop stale toolchain fields (#6114)
### What changes were proposed in this PR?
Three toolchain declarations had drifted from what the project actually
targets:
| File | Before | After |
| --- | --- | --- |
| `bin/y-websocket-server/Dockerfile` | `FROM node:latest` (floating;
image referenced by `bin/k8s`) | `FROM node:24-slim`, matching the
project's Node 24 |
| `frontend/.nvmrc` | `lts/*` plus stray `engine-strict=true` /
`save-exact=true` lines (`.npmrc` keys that nvm cannot parse and yarn 4
ignores) | `24`, matching `engines.node >=24` and CI's Node 24 |
| `agent-service/package.json` | `"packageManager": "yarn@4.5.1"` |
removed — the service is Bun-managed (`bun.lock`; CI runs `bun install`
/ `bun test`) |
Intentionally left alone: `bin/pylsp/Dockerfile` stays on
`python:3.10-slim` (its pinned `python-lsp-server==1.5.0` /
`pylint==2.15.10` predate Python 3.12), and agent-service's own `0.1.0`
version.
### Any related issues, documentation, discussions?
Closes #6109
### How was this PR tested?
- `docker build` of `bin/y-websocket-server` succeeds on `node:24-slim`;
a smoke-run container (`docker run -p 12345:1234`) answered HTTP 200 and
logged the expected `running at '0.0.0.0' on port 1234`.
- `cd agent-service && bun install --frozen-lockfile && bun test` — 115
pass, 0 fail.
- `python3 -c "import json;
json.load(open('agent-service/package.json'))"` confirms the JSON stays
valid.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Fable 5)
Co-authored-by: Claude Fable 5 <no...@anthropic.com>
---
agent-service/package.json | 3 +--
bin/y-websocket-server/Dockerfile | 2 +-
frontend/.nvmrc | 4 +---
3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/agent-service/package.json b/agent-service/package.json
index 600372957b..92bd956f1a 100644
--- a/agent-service/package.json
+++ b/agent-service/package.json
@@ -32,6 +32,5 @@
"prettier": "3.8.4",
"tsx": "4.21.0",
"typescript": "6.0.3"
- },
- "packageManager": "yarn@4.5.1+sha512.341db9396b6e289fecc30cd7ab3af65060e05ebff4b3b47547b278b9e67b08f485ecd8c79006b405446262142c7a38154445ef7f17c1d5d1de7d90bf9ce7054d"
+ }
}
diff --git a/bin/y-websocket-server/Dockerfile b/bin/y-websocket-server/Dockerfile
index 0913412ccd..70df94c6f7 100644
--- a/bin/y-websocket-server/Dockerfile
+++ b/bin/y-websocket-server/Dockerfile
@@ -25,7 +25,7 @@
# has yet to be fully endorsed by the ASF.
# Use an official Node runtime as a parent image
-FROM node:latest
+FROM node:24-slim
# Set the working directory in the container
WORKDIR /usr/src/app
diff --git a/frontend/.nvmrc b/frontend/.nvmrc
index d72a1fef23..a45fd52cc5 100644
--- a/frontend/.nvmrc
+++ b/frontend/.nvmrc
@@ -1,3 +1 @@
-lts/*
-engine-strict=true
-save-exact=true
\ No newline at end of file
+24