[GitHub] shaofengshi commented on a change in pull request #174: KYLIN-3418 adjust hybrid API

[GitBox <gi...@apache.org>]

shaofengshi commented on a change in pull request #174: KYLIN-3418 adjust hybrid API
URL: https://github.com/apache/kylin/pull/174#discussion_r204965852
 
 

 ##########
 File path: server-base/src/main/java/org/apache/kylin/rest/job/HybridCubeCLI.java
 ##########
 @@ -105,6 +105,18 @@ protected void execute(OptionsHelper optionsHelper) throws Exception {
         String projectName = optionsHelper.getOptionValue(OPTION_PROJECT);
         String modelName = optionsHelper.getOptionValue(OPTION_MODEL);
         String cubeNamesStr = optionsHelper.getOptionValue(OPTION_CUBES);
+
+        HybridInstance hybridInstance = hybridManager.getHybridInstance(hybridName);
+
+        if ("delete".equals(action)) {
+            if (hybridInstance == null) {
+                throw new RuntimeException("The Hybrid Cube doesn't exist, could not delete: " + hybridName);
 
 Review comment:
   Please use illegal argument exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services