You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by StefanRRichter <gi...@git.apache.org> on 2018/06/26 12:10:44 UTC

[GitHub] flink issue #6196: [FLINK-9513] Implement TTL state wrappers factory and ser...

Github user StefanRRichter commented on the issue:

    https://github.com/apache/flink/pull/6196
  
    Thanks for the nice contribution. I had some comments inline. In particular three points about the serializer. I would suggest to avoid the use of raw types. I would also suggest to avoid using streaming API at least methods that can appear in hot loops (mainly copy, de/serialize) for performance reasons. I think the imperative style code will not even be (much) longer in those cases. Last, I suggest to always test new serializers via the `SerializerTestBase` because this catches many problems with little effort.


---