You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2010/02/11 16:16:58 UTC
svn commit: r909018 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt
Date: Thu Feb 11 15:16:55 2010
New Revision: 909018
URL: http://svn.apache.org/viewvc?rev=909018&view=rev
Log:
Proposal
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=909018&r1=909017&r2=909018&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Feb 11 15:16:55 2010
@@ -311,3 +311,8 @@
http://svn.apache.org/viewvc?rev=908759&view=rev
+1: markt, kkolinko
-1:
+
+* More memory leak prevention - clear the resource bundle cache
+ http://svn.apache.org/viewvc?rev=909017&view=rev
+ +1: markt
+ -1:
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r909018 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
On 11/02/2010 16:19, Konstantin Kolinko wrote:
> 2010/2/11 <ma...@apache.org>:
>> Author: markt
>> Date: Thu Feb 11 15:16:55 2010
>> New Revision: 909018
>>
>> URL: http://svn.apache.org/viewvc?rev=909018&view=rev
>> Log:
>> Proposal
>>
>> Modified:
>> tomcat/tc6.0.x/trunk/STATUS.txt
>>
>
>> +
>> +* More memory leak prevention - clear the resource bundle cache
>> + http://svn.apache.org/viewvc?rev=909017&view=rev
>> + +1: markt
>> + -1:
>
> In overall looks good, though
>
> 1. Javadoc for ResourceBundle.clearCache(ClassLoader) says that it is @since 1.6
>
> As TC 6 can run on Java 5, reflective access is needed here.
Great :(
I'll withdraw the patch on that basis.
> 2. Re: JspServletWrapper.java
I'll look into this some more.
Thanks for the review.
Mark
>
> I'd be better to clear the cache a few lines later:
> after the servlet is destroyed, as it can load resources while destroying.
> (in a finally{} block?, after instanceManager.destroyInstance(theServlet) call)
>
> Also, I had some doubts, as this place is not exactly where the
> JspLoader was created.
> Some search shows that JspCompilationContext.compile() sets
> JspCompilationContext.jspLoader to null. Maybe that will result in a
> leak when recompiling updated JSP.
>
> Best regards,
> Konstantin Kolinko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r909018 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/2/11 <ma...@apache.org>:
> Author: markt
> Date: Thu Feb 11 15:16:55 2010
> New Revision: 909018
>
> URL: http://svn.apache.org/viewvc?rev=909018&view=rev
> Log:
> Proposal
>
> Modified:
> tomcat/tc6.0.x/trunk/STATUS.txt
>
> +
> +* More memory leak prevention - clear the resource bundle cache
> + http://svn.apache.org/viewvc?rev=909017&view=rev
> + +1: markt
> + -1:
In overall looks good, though
1. Javadoc for ResourceBundle.clearCache(ClassLoader) says that it is @since 1.6
As TC 6 can run on Java 5, reflective access is needed here.
2. Re: JspServletWrapper.java
I'd be better to clear the cache a few lines later:
after the servlet is destroyed, as it can load resources while destroying.
(in a finally{} block?, after instanceManager.destroyInstance(theServlet) call)
Also, I had some doubts, as this place is not exactly where the
JspLoader was created.
Some search shows that JspCompilationContext.compile() sets
JspCompilationContext.jspLoader to null. Maybe that will result in a
leak when recompiling updated JSP.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org